Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved error handling #70

Merged
merged 30 commits into from
Sep 7, 2022
Merged

Improved error handling #70

merged 30 commits into from
Sep 7, 2022

Commits on Aug 23, 2022

  1. discoverConnections has no errors to return 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    51e654a View commit details
    Browse the repository at this point in the history

  2. error if parsing k8s object fails 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    72c7c2c View commit details
    Browse the repository at this point in the history

  3. Types for reporting file-processing errors 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    0cc6fcd View commit details
    Browse the repository at this point in the history

  4. Functions to return multiple error objects 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    555c61b View commit details
    Browse the repository at this point in the history

  5. unit testing 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    eca78b1 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2022

  1. Merge branch 'main' into improved_error_handling

    @zivnevo
    zivnevo committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    866bb8e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. not exporting parse functions 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4fe9786 View commit details
    Browse the repository at this point in the history

  2. ScanK8sDeployObject -> ScanK8sWorkloadObject 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    f1cbaa2 View commit details
    Browse the repository at this point in the history

  3. Moving regexs to vars at the top of the file 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    bea96f0 View commit details
    Browse the repository at this point in the history

  4. Moving error type to controller package 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    292ab3a View commit details
    Browse the repository at this point in the history

  5. discard FileProcessingErrorList 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    dc760f9 View commit details
    Browse the repository at this point in the history

  6. error should not start with a capital letter 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    619d6e1 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Merge branch 'main' into improved_error_handling

    @zivnevo
    zivnevo committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    31e98d5 View commit details
    Browse the repository at this point in the history

  2. create all error objects in error_types.go 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    331182a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. DocumentID() returns an error + Location() method 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    85dced6 View commit details
    Browse the repository at this point in the history

  2. Work with externally-provided logger 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2150312 View commit details
    Browse the repository at this point in the history

  3. A missing not 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    593a495 View commit details
    Browse the repository at this point in the history

  4. implemented stop-on-first-error option 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    196fa2a View commit details
    Browse the repository at this point in the history

  5. Merge branch 'improved_error_handling' of github.com:np-guard/cluster… 

    …-topology-analyzer into improved_error_handling

Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2c043cc View commit details
    Browse the repository at this point in the history

  6. Fix lint issue 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    24c3749 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2022

  1. report line number when marshaling fails 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    61d02ac View commit details
    Browse the repository at this point in the history

  2. PoliciesFromFolderPath() -> PoliciesSynthesizer 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 1, 2022
    Configuration menu
    Copy the full SHA
    aba244d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Logger.Errorf() takes error as an arg 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    3ff6fd3 View commit details
    Browse the repository at this point in the history

  2. A missing check to stop on first error 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    23af03a View commit details
    Browse the repository at this point in the history

  3. Always stop processing on fatal error 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    946f0ea View commit details
    Browse the repository at this point in the history

  4. Not assuming a severe error is always last 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    b666218 View commit details
    Browse the repository at this point in the history

  5. separate logging from custom error interface 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    64f2146 View commit details
    Browse the repository at this point in the history

  6. not relying on fatal error being the last error 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    7e13a74 View commit details
    Browse the repository at this point in the history

  7. Do not rely on fatal errors to be last 

    Signed-off-by: Ziv Nevo <[email protected]>
    @zivnevo
    zivnevo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    4bca39e View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Merge branch 'main' into improved_error_handling

    @zivnevo
    zivnevo committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ab39190 View commit details
    Browse the repository at this point in the history