Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodFromCoreObject required fix #44

Open
adisos opened this issue Nov 24, 2022 · 3 comments
Open

PodFromCoreObject required fix #44

adisos opened this issue Nov 24, 2022 · 3 comments
Labels

Comments

@adisos
Copy link
Collaborator

adisos commented Nov 24, 2022

PodFromCoreObject should not always issue an error / ignore pods not scheduled or not assigned IP addresses.
Only on live cluster mode this is relevant, as opposed to handling pod resources from dir.

@elevran
Copy link
Collaborator

elevran commented Nov 28, 2022

@adisos - might a workaround (instead of passing the "live or file based mode" to PodToCoreObject) be to assign a fake IP to all Pods read from files?
Can probably set up a network+netmask from netip and then call Next() on it to generate the addresses (careful no to overlap with CIDR's being queried - CGNAT or localhost ranges may be a reasonable base)

@adisos
Copy link
Collaborator Author

adisos commented Nov 28, 2022

@adisos - might a workaround (instead of passing the "live or file based mode" to PodToCoreObject) be to assign a fake IP to all Pods read from files? Can probably set up a network+netmask from netip and then call Next() on it to generate the addresses (careful no to overlap with CIDR's being queried - CGNAT or localhost ranges may be a reasonable base)

Right, sounds good. Will consider this option as well to handle this issue.

@adisos adisos self-assigned this Dec 11, 2022
@adisos adisos added the bug Something isn't working label May 8, 2023
@shireenf-ibm
Copy link
Contributor

shireenf-ibm commented May 9, 2023

A merged PR127 resolves this bug (by assigning a fake IP to Pods from files).
However, keeping this issue open in order to consider using the netip for generating the fake ips in the future.

@adisos adisos removed the bug Something isn't working label May 9, 2023
@adisos adisos added the low_prio label Jun 5, 2023
@adisos adisos removed their assignment Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants