Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize internal packages #48

Open
1 of 3 tasks
adisos opened this issue Dec 1, 2022 · 0 comments
Open
1 of 3 tasks

Reorganize internal packages #48

adisos opened this issue Dec 1, 2022 · 0 comments
Assignees

Comments

@adisos
Copy link
Collaborator

adisos commented Dec 1, 2022

  • For example, IPBlock should not be within k8s package

  • consider moving some of the k8s.Peer-related code in eval/check.go to internal/k8s/peer.go, e.g., isPodToItself() and isPeerNodeIP(). Ideally, eval should work on a more abstract level.

  • some of the files (e.g., ipBlock.go) are missing the license header.

@adisos adisos mentioned this issue Dec 1, 2022
@adisos adisos self-assigned this Dec 11, 2022
@adisos adisos removed their assignment Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants