Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidatePosition #25

Open
Hindi opened this issue Mar 19, 2021 · 2 comments
Open

ValidatePosition #25

Hindi opened this issue Mar 19, 2021 · 2 comments

Comments

@Hindi
Copy link

Hindi commented Mar 19, 2021

Hi,

Looking at how you handle movements,it seems that you do not handle the Z coordinate correctly when moving without attacking : when l2creatures move, you update the X and Y coordinates but not Z, so when ValidatePosition is sent, Z is incorrect. Am I right here or did I miss something? Is using geodata the only way to fix that?

Subsidiary question: Have you taken a look at protocol 140? I'm trying to figure out the last int sent by the client in ValidatePosition. It looks a bit random even during a single move (it comes after vehicleId).

@npetrovski
Copy link
Owner

Hi.
If you referring L2Creatures -> setMovingTo() I am afraid you are right - I am using a 2D Vector for calculating the position taking into account only X and Y. I guess I can work on this issue very soon and use 3-dimensional Vector in order to calculate X,Y and Z

Thank you

@Hindi
Copy link
Author

Hindi commented Mar 20, 2021

I don't really need it, but I'm wondering how things work out in places where the Z coordinates changes alot (ToI for example). Do you think averaging the Z value will be enough? Beacause using the geodata will be a pain to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants