Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature request: pass opts.signal #276

Open
jdalton opened this issue Feb 8, 2025 · 2 comments
Open

feature request: pass opts.signal #276

jdalton opened this issue Feb 8, 2025 · 2 comments
Labels
Enhancement new feature or improvement

Comments

@jdalton
Copy link

jdalton commented Feb 8, 2025

pass opts.signal to make-fetch-happen.
@wraithgar
Copy link
Member

Could you go into more detail here? What sets this? What would use it?

@jdalton
Copy link
Author

jdalton commented Feb 8, 2025

make-fetch-happen will call minipass-fetch under the hood which accepts the signal option like fetch.
https://github.com/npm/minipass-fetch/blob/e4df956af7c79cecc7dff8f3edb98cc263e0064c/lib/request.js#L66-L69

@wraithgar wraithgar added the Enhancement new feature or improvement label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement new feature or improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @wraithgar