From fc74d2da28285586c58324428c5baac8b6396c82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=82=BA=E4=BB=80=E9=BA=BC?= Date: Thu, 8 Nov 2018 17:05:45 +0800 Subject: [PATCH 1/3] change the framework to net461 because 4.5 is too old --- src/NReco.Recommender.Tests/NReco.Recommender.Tests.csproj | 6 ++++-- src/NReco.Recommender/NReco.Recommender.csproj | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/src/NReco.Recommender.Tests/NReco.Recommender.Tests.csproj b/src/NReco.Recommender.Tests/NReco.Recommender.Tests.csproj index 0c7d49e..1cd6091 100644 --- a/src/NReco.Recommender.Tests/NReco.Recommender.Tests.csproj +++ b/src/NReco.Recommender.Tests/NReco.Recommender.Tests.csproj @@ -1,5 +1,5 @@  - + Debug @@ -9,7 +9,7 @@ Properties NReco.Recommender.Tests NReco.Recommender.Tests - v4.0 + v4.6.1 512 @@ -21,6 +21,7 @@ DEBUG;TRACE prompt 4 + false pdbonly @@ -29,6 +30,7 @@ TRACE prompt 4 + false diff --git a/src/NReco.Recommender/NReco.Recommender.csproj b/src/NReco.Recommender/NReco.Recommender.csproj index 3f6c752..d9dfe8d 100644 --- a/src/NReco.Recommender/NReco.Recommender.csproj +++ b/src/NReco.Recommender/NReco.Recommender.csproj @@ -1,5 +1,5 @@  - + Debug @@ -9,7 +9,7 @@ Properties NReco.Recommender NReco.Recommender - v4.0 + v4.6.1 512 @@ -22,6 +22,7 @@ prompt 4 bin\Debug\NReco.Recommender.XML + false pdbonly @@ -31,6 +32,7 @@ prompt 4 bin\Release\NReco.Recommender.XML + false From 828b3eb64c93398b1c0e03483add3b1ada6ddb71 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=82=BA=E4=BB=80=E9=BA=BC?= Date: Thu, 8 Nov 2018 17:37:41 +0800 Subject: [PATCH 2/3] change the library to .netstandard format support .net461 and .netStandard2.0 . all unit test passed. --- .../NReco.Recommender.csproj | 423 ++---------------- .../Properties/AssemblyInfo.cs | 36 -- 2 files changed, 29 insertions(+), 430 deletions(-) delete mode 100644 src/NReco.Recommender/Properties/AssemblyInfo.cs diff --git a/src/NReco.Recommender/NReco.Recommender.csproj b/src/NReco.Recommender/NReco.Recommender.csproj index d9dfe8d..442af2f 100644 --- a/src/NReco.Recommender/NReco.Recommender.csproj +++ b/src/NReco.Recommender/NReco.Recommender.csproj @@ -1,399 +1,34 @@ - - - + + - Debug - AnyCPU - {A5DA1BF8-7601-45FC-A906-F61AC63D8EE7} - Library - Properties - NReco.Recommender - NReco.Recommender - v4.6.1 - 512 - + net461;netstandard2.0 + true + 1.0.0.0 + NReco + NReco + Copyright (C) NReco, 2018 + https://github.com/nreco/recommender + https://github.com/nreco/recommender.git + git - - true - full - false - bin\Debug\ - DEBUG;TRACE - prompt - 4 - bin\Debug\NReco.Recommender.XML - false - - - pdbonly - true - bin\Release\ - TRACE - prompt - 4 - bin\Release\NReco.Recommender.XML - false - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Code - - - Code - - - Code - - - - Code - - - - - - - - - - - - Code - - - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - Code - - - - - - - - Code - - - - - - - - - - - - Code - - - - Code - - - Code - - + - - - + + + + + + + + + + + + + + + + - - + \ No newline at end of file diff --git a/src/NReco.Recommender/Properties/AssemblyInfo.cs b/src/NReco.Recommender/Properties/AssemblyInfo.cs deleted file mode 100644 index bd32968..0000000 --- a/src/NReco.Recommender/Properties/AssemblyInfo.cs +++ /dev/null @@ -1,36 +0,0 @@ -using System.Reflection; -using System.Runtime.CompilerServices; -using System.Runtime.InteropServices; - -// General Information about an assembly is controlled through the following -// set of attributes. Change these attribute values to modify the information -// associated with an assembly. -[assembly: AssemblyTitle("NReco.Recommender")] -[assembly: AssemblyDescription("Recommender is a .NET port of Apache Mahout Collaborative Filtering engine (standalone non-Hadoop implementation). Recommendation mining takes users' behaviour and suggests items users might like (both user-based and item-based recommendation algorithms are supported). Recommender can be used for suggesting products, movies, music etc.")] -[assembly: AssemblyConfiguration("")] -[assembly: AssemblyCompany("Vitalii Fedorchenko")] -[assembly: AssemblyProduct("NReco.Recommender")] -[assembly: AssemblyCopyright("Copyright © Vitalii Fedorchenko 2014-2015")] -[assembly: AssemblyTrademark("")] -[assembly: AssemblyCulture("")] - -// Setting ComVisible to false makes the types in this assembly not visible -// to COM components. If you need to access a type in this assembly from -// COM, set the ComVisible attribute to true on that type. -[assembly: ComVisible(false)] - -// The following GUID is for the ID of the typelib if this project is exposed to COM -[assembly: Guid("91bbbc68-48a8-4cb4-811a-67ad0d2b8afb")] - -// Version information for an assembly consists of the following four values: -// -// Major Version -// Minor Version -// Build Number -// Revision -// -// You can specify all the values or you can default the Build and Revision Numbers -// by using the '*' as shown below: -// [assembly: AssemblyVersion("1.0.*")] -[assembly: AssemblyVersion("1.0.0.0")] -[assembly: AssemblyFileVersion("1.0.0.0")] From 6c3f4c59c8fa29679ebbffefea4e7e0a28a8b970 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=82=BA=E4=BB=80=E9=BA=BC?= Date: Thu, 8 Nov 2018 18:22:18 +0800 Subject: [PATCH 3/3] add support in .net40 . summary : 1. change library to .netstandard project format 2. support .net40 .net 461 and .netstandard2.0 (not support .netStandard1.3 because ICloneable is not implemented in 1.3) 3. all test passed --- src/NReco.Recommender/NReco.Recommender.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NReco.Recommender/NReco.Recommender.csproj b/src/NReco.Recommender/NReco.Recommender.csproj index 442af2f..58e2774 100644 --- a/src/NReco.Recommender/NReco.Recommender.csproj +++ b/src/NReco.Recommender/NReco.Recommender.csproj @@ -1,7 +1,7 @@  - net461;netstandard2.0 + net40;net461;netstandard2.0 true 1.0.0.0 NReco