Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The generated configuration files don't satisfy the requirements for the simplified graph testcase. #11

Open
alehed opened this issue May 10, 2018 · 4 comments
Open

The generated configuration files don't satisfy the requirements for the simplified graph testcase. #11

alehed opened this issue May 10, 2018 · 4 comments

Comments

@alehed
Copy link
Collaborator

alehed commented May 10, 2018

Note that in the ideal case, it would never hit this error because #9 would be correct and abort the generation.

  • Test case: test_writing_simplified_bgp_configuration in grigori's 'tests/test_bgpgen.py'. Run it and then test the configuration using dynamips and python grigori/checking/network.py var/possible_bgp/.
@ahassany
Copy link
Member

Is this still an issue?

@alehed
Copy link
Collaborator Author

alehed commented May 28, 2018

Yep, the check fails when the link ('Kilcarbery', 'TDCTT(TrinityTTCollegeTTDublin)') has been taken down.

@ahassany
Copy link
Member

are you checking the return of p.compute_dags() before proceeding?

@alehed
Copy link
Collaborator Author

alehed commented May 28, 2018

The result of p.compute_dags() is non-empty but we established that this was a false negative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahassany @alehed