From aab1cf607624f03fbedcac9756aad767af2f6fda Mon Sep 17 00:00:00 2001 From: Roman Khimov Date: Tue, 10 Sep 2024 19:28:50 +0300 Subject: [PATCH] *: fix exhaustive warnings helpers.go:50:2 exhaustive missing cases in switch of type dbft.MessageType: dbft.RecoveryRequestType, dbft.RecoveryMessageType internal/consensus/recovery_message.go:39:2 exhaustive missing cases in switch of type dbft.MessageType: dbft.RecoveryRequestType, dbft.RecoveryMessageType Signed-off-by: Roman Khimov --- helpers.go | 3 +++ internal/consensus/recovery_message.go | 2 ++ 2 files changed, 5 insertions(+) diff --git a/helpers.go b/helpers.go index 975b8453..9f2ab935 100644 --- a/helpers.go +++ b/helpers.go @@ -56,5 +56,8 @@ func (c *cache[H]) addMessage(m ConsensusPayload[H]) { msgs.preCommit[m.ValidatorIndex()] = m case CommitType: msgs.commit[m.ValidatorIndex()] = m + default: + // Others are recoveries and we don't currently use them. + // Theoretically messages could be extracted. } } diff --git a/internal/consensus/recovery_message.go b/internal/consensus/recovery_message.go index ae9f8a46..d6b43b18 100644 --- a/internal/consensus/recovery_message.go +++ b/internal/consensus/recovery_message.go @@ -65,6 +65,8 @@ func (m *recoveryMessage) AddPayload(p dbft.ConsensusPayload[crypto.Uint256]) { } copy(cc.Signature[:], p.GetCommit().Signature()) m.commitPayloads = append(m.commitPayloads, cc) + default: + // Other types (recoveries) can't be packed into recovery. } }