formal-models: extend dBFT with additional post-commit phase #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
=======================================
Coverage 63.31% 63.31%
=======================================
Files 27 27
Lines 1510 1510
=======================================
Hits 956 956
Misses 489 489
Partials 65 65 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
force-pushed
the
add-postblock-handling
branch
from
37c84f9
to
7125076
Compare
AnnaShaleva
force-pushed
the
add-postblock-handling
branch
2 times, most recently
from
2b6c4cf
to
0095b94
Compare
AnnaShaleva
force-pushed
the
add-postblock-handling
branch
from
0095b94
to
847c944
Compare
|
Ready for review. @roman-khimov, I think the best way to review it is to check the |
AnnaShaleva
force-pushed
the
add-postblock-handling
branch
from
847c944
to
5124528
Compare
Close #111. The additional step is called RMSendAck and allows to send Ack message once enough Commit messages are received. Block can be accepted only if BFT number of Ack messages are collected. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
add-postblock-handling
branch
from
5124528
to
de50c7b
Compare
|
@roman-khimov, ready for review. |
roman-khimov
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #111.
The extended model includes additional
ackSentRM state and additionalAckmessage type. Speaking in terms of anti-MEV solution,preBlockapproval corresponds to thecommitSentRM state, and the only possible transition fromcommitSentstage is to move toackSentstage viaAckmessage sending (Blockapproval).Presented model has the same 4-nodes deadlock scenario with a single dead node described in neo-project/neo-modules#792 (comment):
Also, the presented model has additional
TerminatingFourNodesDeadlockaction that allows infinite stuttering in the described deadlock to enable further model checking. If this action is enabled, then one more deadlock is being found (not related to the additional phase), this deadlock is yet another face of the same liveness lock described previously:TODO: