Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbft: improve "ignoring"-related debug messages #88

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

AnnaShaleva
Copy link
Member

PrepareRequest and PrepareResponse are ignored not only because of view changing. Wrong log is misleading, so we'd better have the log that reflects the real state of things.

PrepareRequest and PrepareResponse are ignored not only because of view
changing. Wrong log is misleading, so we'd better have the log that reflects
the real state of things.

Signed-off-by: Anna Shaleva <[email protected]>
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (8b6cbaa) 75.17% compared to head (3ff22d5) 74.94%.

Files Patch % Lines
dbft.go 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   75.17%   74.94%   -0.23%     
==========================================
  Files          24       24              
  Lines        1309     1313       +4     
==========================================
  Hits          984      984              
- Misses        271      275       +4     
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 6d59675 into master Jan 30, 2024
5 of 7 checks passed
@roman-khimov roman-khimov deleted the adj-cv-logs branch January 30, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants