Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NeoFS chains compatibility with hardfork-dependent Notary contract #3465

Closed
AnnaShaleva opened this issue May 27, 2024 · 3 comments
Closed
Assignees
Labels
I4 No visible changes S2 Regular significance task Something to do test Unit tests U2 Seriously planned

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented May 27, 2024

Depends on the draft implementation of #3464. Ref. neo-project/neo#3178 (comment).

  1. Find the most early usage of Notary contract in NeoFS mainnet and testnet. Let it be X and Y height.
  2. Take the branch from Move Notary contract under D hardfork #3464, build the node.
  3. Take the https://github.com/nspcc-dev/neo-go/blob/master/config/protocol.mainnet.neofs.yml and https://github.com/nspcc-dev/neo-go/blob/master/config/protocol.testnet.neofs.yml, enable B, Cand D hardforks to X-1 and Y-1 correspondingly for mainnet and testnet.
  4. Process both NeoFS mainnet and testnet with Move Notary contract under D hardfork #3464 and updated configurations.
  5. Compare containers and netmap with scripts: add script for containers and netmap entries comparison neofs-contract#399.

Write in the comment what are X and Y heights, what is the result of step 5.

@AnnaShaleva AnnaShaleva added test Unit tests U2 Seriously planned S2 Regular significance I4 No visible changes labels May 27, 2024
@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone May 27, 2024
@roman-khimov roman-khimov added the task Something to do label May 27, 2024
@AnnaShaleva
Copy link
Member Author

For the record, data for NeoFS mainnet:

  • The first appearance of transaction with Notary contract as a signer is 3519285.
  • The first appearance of transaction with NotaryAssisted attribute is the same (which is expected) 3519285.
  • The first appearance of transaction with funds transferred to Notary contract is a bit earlier (which is also expected): 3519100.

Aspidochelone starts from 3000000. Thus, I suggest to test the following settings for mainnet:

  Hardforks:
    Aspidochelone: 3000000
    Basilisk: 3500000
    Cockatrice: 3500000
    Domovoi: 3500000

Testnet is not affected by this problem since all hardforks are active from genesis.

@roman-khimov, ACK?

@roman-khimov
Copy link
Member

Perfect, yes.

AnnaShaleva added a commit that referenced this issue Jun 7, 2024
@AnnaShaleva
Copy link
Member Author

AnnaShaleva commented Jun 7, 2024

We're free to move on with Notary! Checked on bc8ca6d with Notary contract under HF D.

anna@kiwi:~/Documents/GitProjects/nspcc-dev/neofs-contract$ go run scripts/compare-fscontent/compare-fscontent.go http://localhost:40332 https://rpc1.morph.fs.neo.org:40341
RPC http://localhost:40332 height: 5815701
RPC https://rpc1.morph.fs.neo.org:40341 height: 5815701
number of containers checked: 179
number of netmap entries checked: 5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I4 No visible changes S2 Regular significance task Something to do test Unit tests U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

3 participants