Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating index files in uploader should look at last incomplete batch and finish without error #3669

Open
AliceInHunterland opened this issue Nov 11, 2024 · 1 comment
Assignees
Labels
bug Something isn't working cli Command line interface I3 Minimal impact S3 Minimally significant U2 Seriously planned
Milestone

Comments

@AliceInHunterland
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  |   | 2024-11-11 07:21:18.049 | Index file 51: fetching missing block 6528014 |  
  |   | 2024-11-11 07:20:50.957 | Index file 51: fetching missing block 6528013 |  
  |   | 2024-11-11 07:20:50.957 | Index file 51 generated, checking for the missing blocks... |  
  |   | 2024-11-11 07:13:21.266 | Uploading index files... |  
  |   | 2024-11-11 07:13:21.266 | First block of latest incomplete batch uploaded to NeoFS container: 6590000 |  
  |   | 2024-11-11 07:12:17.371 | Chain block height: 6669814

It should not fetching, but stopping.

Describe the solution you'd like

func uploadBlocks(ctx *cli.Context, p *pool.Pool, rpc *rpcclient.Client, signer user.Signer, containerID cid.ID, acc *wallet.Account, attr string, oldestMissingBlockIndex int, currentBlockHeight uint, homomorphicHashingDisabled bool, numWorkers, maxRetries int)

Add oldestMissingBlockIndex as a parameter and calculate the number of index files based on it.

Describe alternatives you've considered

Errors at the end.

@AliceInHunterland AliceInHunterland added bug Something isn't working I2 Regular impact U2 Seriously planned cli Command line interface S3 Minimally significant labels Nov 11, 2024
@AliceInHunterland AliceInHunterland self-assigned this Nov 11, 2024
@AnnaShaleva AnnaShaleva added I3 Minimal impact and removed I2 Regular impact labels Nov 11, 2024
@AnnaShaleva
Copy link
Member

Errors at the end.

Let's not consider this as an alternative. The proposed solution to adjust uploadBlocks LGTM.

@AnnaShaleva AnnaShaleva added this to the v0.107.0 milestone Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cli Command line interface I3 Minimal impact S3 Minimally significant U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

2 participants