Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Waiter.Wait() with context parameter #3773

Open
AnnaShaleva opened this issue Dec 20, 2024 · 2 comments
Open

Extend Waiter.Wait() with context parameter #3773

AnnaShaleva opened this issue Dec 20, 2024 · 2 comments
Labels
enhancement Improving existing functionality I3 Minimal impact rpc RPC server and client S3 Minimally significant U4 Nothing urgent

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented Dec 20, 2024

Is your feature request related to a problem? Please describe.

Inspired by @mialbu. Waiter.Wait() doesn't accept context, although Waiter.WaitAny() does. If user need to pass some custom cancellation context to awaiter, then he need to use Waiter.WaitAny() just because of the fact that Waiter.Wait() doesn't accept extra context parameter.

Describe the solution you'd like

Extend Waiter.Wait() with context parameter.

Describe alternatives you've considered

Keep it as is, it's a matter of discussion. Opinions are welcomed.

@AnnaShaleva AnnaShaleva added discussion Open discussion of some problem I2 Regular impact I3 Minimal impact U4 Nothing urgent enhancement Improving existing functionality S4 Routine labels Dec 20, 2024
@roman-khimov roman-khimov added S3 Minimally significant rpc RPC server and client and removed discussion Open discussion of some problem I2 Regular impact S4 Routine labels Dec 20, 2024
@roman-khimov
Copy link
Member

The only problem is that this is a breaking change.

@AnnaShaleva
Copy link
Member Author

Yes, I thought about it, but at the same time it's very easy to migrate from old to new API. And in the past we already included such similar breaking changes (like #3661, although I agree that it's not as widely-used by external users comparing to Actor's functionality).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact rpc RPC server and client S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants