Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document contracts' storage model #275

Closed
cthulhu-rider opened this issue Sep 30, 2022 · 4 comments
Closed

Document contracts' storage model #275

cthulhu-rider opened this issue Sep 30, 2022 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers netmap Netmap contract related issue
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

The memory of contracts has a structural organization, which can change during the update process. When changing the memory model, it is required to write a migration data routine from the previous model. To do this, I propose to document the organization of memory for developers in contracts. It is proposed to start with Netmap contract.

@cthulhu-rider cthulhu-rider added documentation Improvements or additions to documentation good first issue Good for newcomers netmap Netmap contract related issue triage labels Sep 30, 2022
@cthulhu-rider cthulhu-rider self-assigned this Sep 30, 2022
@cthulhu-rider
Copy link
Contributor Author

@fyrchik
Copy link
Contributor

fyrchik commented Sep 30, 2022

See also nspcc-dev/neo-go#2561

cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
Start package docs with commonly used format `Package netmap ...`. Also
make `gofmt` do the job.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider changed the title netmap: Document contract storage model Document contracts' storage model Sep 30, 2022
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Sep 30, 2022
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Jan 27, 2023
Start package docs with commonly used format `Package netmap ...`. Also
make `gofmt` do the job.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Jan 27, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Jan 27, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Jan 27, 2023
Start package docs with commonly used format `Package netmap ...`.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Jan 27, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Jan 30, 2023
Actualize storage node's structure type and clarify this is a type not
to cause misunderstanding.

Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov pushed a commit that referenced this issue Jan 30, 2023
Start package docs with commonly used format `Package netmap ...`.

Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov pushed a commit that referenced this issue Jan 30, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
roman-khimov pushed a commit that referenced this issue Jan 30, 2023
Actualize storage node's structure type and clarify this is a type not
to cause misunderstanding.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider removed their assignment Jan 31, 2023
@cthulhu-rider
Copy link
Contributor Author

In demand in the context of updates. Lets do this for other contracts.

cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 1, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 1, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 2, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 2, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 2, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 2, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 2, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Feb 2, 2023
Add comments (outside the docs) with key-value storage structure and
some explanations. The memory mode will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider self-assigned this Feb 3, 2023
@roman-khimov roman-khimov modified the milestones: v0.16.1, v0.17.0, v0.18.0 Mar 17, 2023
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Apr 12, 2023
Add comments (outside godoc) with key-value storage scheme and
some explanations. The memory model will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue Apr 12, 2023
Add comments (outside godoc) with key-value storage scheme and
some explanations. The memory model will allow to more precisely
understand and migrate the contract storage.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue May 22, 2023
Add comments (outside godoc) with key-value storage scheme and
some explanations. The memory model will allow to more precisely
understand and migrate the contract storage.

Refs nspcc-dev#275

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue May 24, 2023
Add comments (outside godoc) with key-value storage scheme and
some explanations. The memory model will allow to more precisely
understand and migrate the contract storage.

Refs nspcc-dev#275

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit to cthulhu-rider/neofs-contract that referenced this issue May 24, 2023
Add comments (outside godoc) with key-value storage scheme and
some explanations. The memory model will allow to more precisely
understand and migrate the contract storage.

Refs nspcc-dev#275

Signed-off-by: Leonard Lyubich <[email protected]>
@roman-khimov
Copy link
Member

Closing this one, because #320 was merged quite some time ago. The only thing left is NNS, that'd be #362.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers netmap Netmap contract related issue
Projects
None yet
Development

No branches or pull requests

3 participants