Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated API from container contract #312

Open
AnnaShaleva opened this issue Jan 27, 2023 · 1 comment
Open

Remove duplicated API from container contract #312

AnnaShaleva opened this issue Jan 27, 2023 · 1 comment
Labels
blocked Can't be done because of something container Container contract related issue I3 Minimal impact S3 Minimally significant U4 Nothing urgent

Comments

@AnnaShaleva
Copy link
Member

Method

func List(owner []byte) [][]byte {

returns the list of all container IDs owned by the specified user. In case of the nil user it iterates over the whole container list, which can easily exceed the MaxStackSize (2048) constraint.
We have
func ContainersOf(owner []byte) iterator.Iterator {
introduced in #300 that returns the same result in the form of iterator, so we'd better remove List at all (or at least forbid empty owner parameter for this method).

Ref. #304.

@roman-khimov
Copy link
Member

It's needed for compatibility reasons for now. This can be done in future, when we have all users of it migrated.

@roman-khimov roman-khimov added container Container contract related issue blocked Can't be done because of something labels Jan 27, 2023
@roman-khimov roman-khimov added U3 Regular S3 Minimally significant I3 Minimal impact U4 Nothing urgent and removed U3 Regular labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't be done because of something container Container contract related issue I3 Minimal impact S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants