Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iterators for reputation contract #315

Open
AnnaShaleva opened this issue Jan 27, 2023 · 0 comments
Open

Use iterators for reputation contract #315

AnnaShaleva opened this issue Jan 27, 2023 · 0 comments
Labels
enhancement Improving existing functionality I3 Minimal impact reputation Reputation contract related issue S3 Minimally significant U3 Regular
Milestone

Comments

@AnnaShaleva
Copy link
Member

Methods Get and GetByID restrict the maximum number of DataAuditResult with 2047 items (per epoch per node).
It may be critical for Get and GetByID returning an array of audit results for a certain epoch made by a single IR node in case of a large amount of audit results, so we need to return iterator from these methods.

IIUC, ListByEpoch is not affected and may be kept as is because it returns IRNodesCount results at max (hardly ever we have the number of IR nodes more than 2047).

Ref. #304.

@roman-khimov roman-khimov added enhancement Improving existing functionality reputation Reputation contract related issue labels Jan 27, 2023
@roman-khimov roman-khimov added U3 Regular S3 Minimally significant I3 Minimal impact labels Dec 20, 2023
@roman-khimov roman-khimov added this to the v0.21.0 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact reputation Reputation contract related issue S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants