You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
according to @carpawell and @AnnaShaleva remarks, logging of Sidechain deployment routine should be improved in terms of severity and message contents. Overall I agree, but procedure contains a LOT of different conditions and cases, and we should analyze them one-by-one accurately. Since log is log and doesn't affect core behavior much, we decided to resolve log messages (both content and severity levels) within this issue.
it may be also useful to wait until first practical use-cases: with them we'll be able to "beautify" log more objectively
The text was updated successfully, but these errors were encountered:
What we need here is to remove (or convert to DEBUG-level) all logs that are related to the non-suitable notary requests received by the auto-deploy routine. This routine listens to all notary requests signed by the committee. Current code writes INFO-level logs in the following situations:
if Removed event received (removal of notary request from pool
If some non-related notary request with invalid number of signers is received
If received notary request is signed by the receiver node
etc...
IMO, all these situations are not an error, these messages are a part of a standard receiving flow, thus I doubt we should log them at all.
according to @carpawell and @AnnaShaleva remarks, logging of Sidechain deployment routine should be improved in terms of severity and message contents. Overall I agree, but procedure contains a LOT of different conditions and cases, and we should analyze them one-by-one accurately. Since log is log and doesn't affect core behavior much, we decided to resolve log messages (both content and severity levels) within this issue.
it may be also useful to wait until first practical use-cases: with them we'll be able to "beautify" log more objectively
The text was updated successfully, but these errors were encountered: