Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise log messages of Sidechain auto-deployment procedure #408

Open
cthulhu-rider opened this issue Jul 5, 2023 · 4 comments
Open

Revise log messages of Sidechain auto-deployment procedure #408

cthulhu-rider opened this issue Jul 5, 2023 · 4 comments
Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Jul 5, 2023

according to @carpawell and @AnnaShaleva remarks, logging of Sidechain deployment routine should be improved in terms of severity and message contents. Overall I agree, but procedure contains a LOT of different conditions and cases, and we should analyze them one-by-one accurately. Since log is log and doesn't affect core behavior much, we decided to resolve log messages (both content and severity levels) within this issue.

it may be also useful to wait until first practical use-cases: with them we'll be able to "beautify" log more objectively

@AnnaShaleva
Copy link
Member

What we need here is to remove (or convert to DEBUG-level) all logs that are related to the non-suitable notary requests received by the auto-deploy routine. This routine listens to all notary requests signed by the committee. Current code writes INFO-level logs in the following situations:

  • if Removed event received (removal of notary request from pool
  • If some non-related notary request with invalid number of signers is received
  • If received notary request is signed by the receiver node
  • etc...

IMO, all these situations are not an error, these messages are a part of a standard receiving flow, thus I doubt we should log them at all.

@AnnaShaleva
Copy link
Member

@carpawell
Copy link
Member

carpawell commented Jul 13, 2023

@roman-khimov roman-khimov added enhancement Improving existing functionality U4 Nothing urgent S4 Routine I3 Minimal impact labels Dec 21, 2023
@carpawell carpawell transferred this issue from nspcc-dev/neofs-node Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

4 participants