Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide subscriptions to network config changes #427

Open
cthulhu-rider opened this issue Aug 8, 2024 · 4 comments
Open

Provide subscriptions to network config changes #427

cthulhu-rider opened this issue Aug 8, 2024 · 4 comments
Labels
feature Completely new functionality I3 Minimal impact netmap Netmap contract related issue S2 Regular significance U2 Seriously planned
Milestone

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Aug 8, 2024

Is your feature request related to a problem? Please describe.

there is no current way to subscribe to changes of the NeoFS network settings. This would improve the system's reaction to reconfigs

Describe the solution you'd like

throw per-config notificaitons by the Netmap contract and subscribe to them from the app side

Describe alternatives you've considered

polling, i.e. long delays and often idle requests

Additional context

@cthulhu-rider cthulhu-rider added the feature Completely new functionality label Aug 8, 2024
@cthulhu-rider cthulhu-rider changed the title Provide subscription to network config changes Provide subscriptions to network config changes Aug 8, 2024
@cthulhu-rider cthulhu-rider transferred this issue from nspcc-dev/neofs-sdk-go Aug 8, 2024
@carpawell
Copy link
Member

What it such a notification is missed?

@cthulhu-rider
Copy link
Contributor Author

wont get any worse than when there are no notifications at all

@carpawell
Copy link
Member

I meant it may get better but the current node code expects to miss any number of notifications at any time, so we cannot rely on it until some changes are done on the nodes side.

@cthulhu-rider
Copy link
Contributor Author

cthulhu-rider commented Aug 9, 2024

practice shows network config changes extremely rarely. With notifications, nodes could use bigger cache time and catch changes by notifications mostly. Yeah, running node can miss a notification, and it will know about the change later. But normally notifications should not be missed. And this seems a better option than more frequent requests when config stays the same for months

so, worst scenario is not worse while the best one is better. And ur right, this will definitely require catch implementation. The costs seem negligible

@roman-khimov roman-khimov added netmap Netmap contract related issue U2 Seriously planned S2 Regular significance I3 Minimal impact labels Aug 12, 2024
@roman-khimov roman-khimov added this to the v0.21.0 milestone Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Completely new functionality I3 Minimal impact netmap Netmap contract related issue S2 Regular significance U2 Seriously planned
Projects
None yet
Development

No branches or pull requests

3 participants