Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why some files are hidden? #169

Open
532910 opened this issue Apr 6, 2022 · 4 comments
Open

why some files are hidden? #169

532910 opened this issue Apr 6, 2022 · 4 comments
Labels
I3 Minimal impact question Further information is requested S4 Routine U4 Nothing urgent

Comments

@532910
Copy link
Contributor

532910 commented Apr 6, 2022

.dockerignore, .gitignore, .git, .editorconfig are hidden, but they are not a part of this project, just a helpers for git and others.

And the question is: why .env, .services and .basic_services start with dot?

@532910 532910 added the triage label Apr 6, 2022
@alexvanin
Copy link
Contributor

¯\(ツ)
I don't think there is a particular reason for that. Moreover other dotenv files such as service/ir/.ir.env and service/storage/.storage.env are also hidden.
Are there any issues with it, though?

@532910
Copy link
Contributor Author

532910 commented Apr 14, 2022

service/ir/.ir.env and service/storage/.storage.env also should be unhidden

@alexvanin
Copy link
Contributor

I don't mind having those files unhidden. Should not affect developer's workflow, however it might require some changes in integration tests. @aprasolova can you check that?

@aprasolova
Copy link
Contributor

aprasolova commented Apr 14, 2022

In integration tests, we only use .int_test.env. It's trivial to support the "unhiding" of the files.
@EliChin

@roman-khimov roman-khimov added U4 Nothing urgent S4 Routine I3 Minimal impact and removed triage labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I3 Minimal impact question Further information is requested S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

5 participants