Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make down/basic does not stop morph #224

Open
carpawell opened this issue Oct 3, 2022 · 5 comments
Open

make down/basic does not stop morph #224

carpawell opened this issue Oct 3, 2022 · 5 comments
Labels
discussion Open discussion of some problem I4 No visible changes S4 Routine U4 Nothing urgent

Comments

@carpawell
Copy link
Member

After #212 there is a new target in the Makefile: (up|down)/bootstrap. It has been added to every up/* but not to all the down/* targets.
As a result down/basic does not return a state after the up/basic. It confused me a little and was not expected of me: every local run was made using the same morph state without any cleaning. Not sure if it is something that we want to have in our makefile. Mb it is a kinda feature and allows caching morph b/w runs.

@carpawell carpawell added question Further information is requested triage U4 Nothing urgent discussion Open discussion of some problem labels Oct 3, 2022
@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Dec 20, 2023

i find current behavior correct:

  1. make down/basic stops services listed in .basic_services and no others
  2. if make up/bootstrap was done 1st, then make up/basic, i don't expected make down/basic to stop the bootstrap services that were run 1st

P.S. after #282 ir (ex. morph_chain) keeps the NeoFS chain between starts intentionally

  • wanna stop all services, do make down
  • wanna reset collected state, do make clean
  • and if u don't, this does not happen

@carpawell
Copy link
Member Author

@cthulhu-rider, dont you think this scenario should be correct:

  1. i have nothing
  2. i do make up/basic
  3. i do make down/basic
  4. i have nothing again?

Why are they named the opposite way then if down does not neutralize up? Isnt morph basic too?

make down/basic stops services listed in .basic_services and no others

Agree, but files/services grouping is kinda of an internal thing. What can make up/bootstrap be useful for? Running neo-go in the neofs-devenv repo?
I think we can reconsider devenv (and this issue) soon after it is not used in the integrational tests (mb that will also mean #212 rollback).

@roman-khimov roman-khimov added S4 Routine I4 No visible changes and removed triage question Further information is requested labels Dec 20, 2023
@roman-khimov
Copy link
Member

Might become irrelevant after #282.

@cthulhu-rider
Copy link
Contributor

@carpawell if paraphrase the original issue text to lets embed "bootstrap" services into the "basic" ones and purge "bootstrap" as a separate component - im only 👍

@carpawell
Copy link
Member Author

lets embed "bootstrap" services into the "basic" ones and purge "bootstrap" as a separate component

Yes, i think it is the closest one to what i would implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open discussion of some problem I4 No visible changes S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

3 participants