Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"make clean" ends with an error #300

Open
tatiana-nspcc opened this issue Dec 4, 2023 · 3 comments
Open

"make clean" ends with an error #300

tatiana-nspcc opened this issue Dec 4, 2023 · 3 comments
Labels
bug Something isn't working I4 No visible changes S4 Routine U4 Nothing urgent

Comments

@tatiana-nspcc
Copy link

Current Behavior

neofs-dev-env (master)$ make clean









storage_s01
storage_s02
storage_s03
storage_s04
Error: The target clean failed with exit code 1
make: *** [Makefile:212: clean] Error 1

Expected Behavior

Something without errors

Possible Solution

I don't know.

Steps to Reproduce

  1. I prepared and ran the environment for test cases according to README.md
  2. Run make clean
@tatiana-nspcc tatiana-nspcc added bug Something isn't working triage labels Dec 4, 2023
@roman-khimov roman-khimov added U4 Nothing urgent S4 Routine I4 No visible changes and removed triage labels Dec 20, 2023
@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Feb 22, 2024

@tatiana-nspcc on error encounter, try to rm storage volume manually:

$ docker volume rm storage_storage_s01

P.S. volume names may change over time, see

$ docker volume ls

u may see an error like this:

Error response from daemon: remove storage_storage_s01: volume is in use - [4dd0d96cd27765cef7c9d7944f13c8b0a6491146477677430e68db99480a2569, 4f8c5ee17272a8cb6fb3953f2b596cf4db1cdbe6821f03c3fbf1f3a8aa057bd3]

in this case u may clean these containers. I usually clean all via:

$ docker container prune

after this, volumes are no longer used, so:

$ make clean
storage_storage_s01
storage_storage_s02
storage_storage_s03
storage_storage_s04
The target 'clean' completed successfully

i noticed that this happens after running https://github.com/nspcc-dev/neofs-testcases above DevEnv. But I don’t exclude other reasons


for used volumes case i see two possible improvements:

  1. rm containers before volumes in make clean
  2. write clear error volume is in use instead of Error: The target clean failed with exit code 1 and add README tip how this could be healed

@tatiana-nspcc
Copy link
Author

You're right. I should manually remove all storage_storage_* volumes. And I'd received an error that they are in use. But in my case docker container prune didn't work, I used:

docker ps --filter "volume=storage_storage_s01"
...
docker stop [container_id]
...
docker rm [container_id]
...
docker volume rm storage_storage_s01

After that, make clean completed successfully.

@cthulhu-rider
Copy link
Contributor

in my case docker container prune didn't work

prune does not remove running containers, thats why u needed docker stop i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I4 No visible changes S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

3 participants