Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Avoid hard-coding blobovnicza tree dir in corruptSubDir func #1407

Closed
cthulhu-rider opened this issue May 20, 2022 · 3 comments
Closed

test: Avoid hard-coding blobovnicza tree dir in corruptSubDir func #1407

cthulhu-rider opened this issue May 20, 2022 · 3 comments

Comments

@cthulhu-rider
Copy link
Contributor

After #1400 function ignores blobovnicza directory. Its name is hard-coded since dir organization in BlobStor is package-closed. We need:

  1. partially export dir info from blobstor package, or
  2. reconsider BlobStor corruption (???)
@fyrchik
Copy link
Contributor

fyrchik commented May 20, 2022

corruptSubDir was written the way it is because the intention was to have tests that ensure file from other (non-corrupted) folders can still be read.

@fyrchik
Copy link
Contributor

fyrchik commented Jun 23, 2022

This can be easily done after #1522 .

@roman-khimov
Copy link
Member

Obsoleted by #2453.

@roman-khimov roman-khimov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fyrchik @roman-khimov @cthulhu-rider