Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store time at which metabase was resynced #2887

Closed
carpawell opened this issue Jul 8, 2024 · 1 comment · Fixed by #2966
Closed

Store time at which metabase was resynced #2887

carpawell opened this issue Jul 8, 2024 · 1 comment · Fixed by #2966
Assignees
@End-rey
Labels
enhancement Improving existing functionality good first issue Good for newcomers I4 No visible changes S3 Minimally significant U4 Nothing urgent
Milestone
v0.44.0

Comments

@carpawell
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when we miss some details about meta when it behaves badly.

Describe the solution you'd like

Store some timestamp that indicates the last metabase resynchronization. Do not think absolute time is a good idea, so epoch can be a better option.

Describe alternatives you've considered

(:

Additional context

Every time we debug metabase is an "additional context".
@carpawell carpawell mentioned this issue Jul 8, 2024
Closed
@roman-khimov roman-khimov added enhancement Improving existing functionality good first issue Good for newcomers U4 Nothing urgent S3 Minimally significant I4 No visible changes labels Jul 16, 2024
@roman-khimov
Copy link
Member

We'll change metabase format a bit in the next version, so we better do this at the same time.

@roman-khimov roman-khimov added this to the v0.44.0 milestone Oct 4, 2024
End-rey added a commit that referenced this issue Oct 9, 2024
@End-rey
metabase: save last epoch when metabase was resynchronized
2ccbd1d 
At `DB` and `Info` structs add field that holds last epoch when metabase was
resynchronized and add method `SaveLastResyncEpoch` that saves this information.

Closes #2887.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey mentioned this issue Oct 9, 2024
Merged
End-rey added a commit that referenced this issue Oct 10, 2024
@End-rey
lens, metabase: save last epoch when metabase was resynchronized
1b3e811 
Add new key `last_resync_epoch` to `shardInfoBucket` in metabase `boltDB` and
new field in `Info` that contains last epoch when metabase was resynchronized.
Update this value in db when the metabase is `Reset` and read on `init`.
Also make `lens` command `meta last-resync-epoch` to read this value from
metabase path. Add test. Update VERSION.md.

Closes #2887.

Signed-off-by: Andrey Butusov <[email protected]>
roman-khimov added a commit that referenced this issue Oct 15, 2024
@roman-khimov
metabase: save last epoch when metabase was resynchronized (#2966)
e254f00 
Closes #2887.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@End-rey End-rey

Labels
enhancement Improving existing functionality good first issue Good for newcomers I4 No visible changes S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
v0.44.0
Development

Successfully merging a pull request may close this issue.

metabase: save last epoch when metabase was resynchronized nspcc-dev/neofs-node
3 participants
@roman-khimov @carpawell @End-rey