Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workflow: Add a deploying Allure reports to NeoFS #2414

Merged
merged 2 commits into from
Jul 28, 2023
Merged

workflow: Add a deploying Allure reports to NeoFS #2414

merged 2 commits into from
Jul 28, 2023

Conversation

vvarg229
Copy link
Contributor

@vvarg229 vvarg229 commented Jul 3, 2023

Added a workflow for deploy Allure tests result as static web page to NeoFS.

This new functionality will help to save any test report as an object in the NeoFS network, we will become independent of the limitations of the GitHub branches and pages.

It will also be an "advertisement" for our object storage.

Examples:
https://github.com/vvarg229/neofs-node/actions/runs/5448658441/jobs/9912093994
https://http.t5.fs.neo.org/86C4P6uJC7gb5n3KkwEGpXRfdczubXyRNW5N9KeJRW73/175-1688419556/index.html

BEFORE MERGING THIS PR IS NECESSARY:

  1. Merge tools: Add a script for deploying Allure reports to NeoFS neofs-testcases#578
  2. Create a wallet in the TestNet or in the MainNet
  3. Fill the balance of the wallet
  4. Create a container for Allure report objects. I'll write this CID in the workflow code.
  5. On the https://github.com/nspcc-dev/neofs-node/settings/secrets/actions create secrets: TEST_RESULTS_PASSWORD (wallet password) and TEST_RESULTS_WALLET (cat wallet.json | json_pp | base64) - @roman-khimov @aprasolova @532910 can you do it?

@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #2414 (01f249a) into master (14ad097) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 01f249a differs from pull request most recent head 6f3fa71. Consider uploading reports for the commit 6f3fa71 to get more accurate results

@@           Coverage Diff           @@
##           master    #2414   +/-   ##
=======================================
  Coverage   29.47%   29.48%           
=======================================
  Files         399      399           
  Lines       30432    30430    -2     
=======================================
  Hits         8971     8971           
+ Misses      20717    20715    -2     
  Partials      744      744
Files Changed Coverage Δ
pkg/services/object/acl/v2/service.go 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vvarg229 vvarg229 force-pushed the upload-pages-artifact branch 3 times, most recently from 5652829 to ca5df0c Compare July 4, 2023 08:53
@vvarg229 vvarg229 marked this pull request as ready for review July 4, 2023 08:54
carpawell
carpawell reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a container for Allure report objects. I'll write this CID in the workflow code.

Shouldn't it be a secret too?

.github/workflows/run-tests.yml Outdated
if: always()
run: |
sudo chmod -R a+rw ${GITHUB_WORKSPACE}/allure-report
source venv.local-pytest/bin/activate && python ./tools/src/process-allure-reports.py --neofs_node $TEST_RESULTS_NEOFS_NODE --run_id $RUN_ID --cid $TEST_RESULTS_CID --allure_report ${GITHUB_WORKSPACE}/allure-report --wallet wallet.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be done via a separate GH action in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it be done via a separate GH action in the future?

Sorry for the late reply.
Running tests will not be done via a separate GH action.

Report generation - yes, it will be done.

@carpawell
Copy link
Member

carpawell commented Jul 4, 2023 •
edited
Loading

BEFORE MERGING THIS PR IS NECESSARY:

Moving the PR to a draft stage if you dont mind.

@carpawell carpawell marked this pull request as draft July 4, 2023 17:41
@vvarg229
Copy link
Contributor Author

vvarg229 commented Jul 4, 2023

Create a container for Allure report objects. I'll write this CID in the workflow code.

Shouldn't it be a secret too?

No, it's not a secret

@carpawell
Copy link
Member

No, it's not a secret

I meant that every container update (it can be compromised, or dropped by mistake, etc) should be done via PR then while keeping it in a secret allows just modifying repo settings.

@vvarg229
Copy link
Contributor Author

vvarg229 commented Jul 5, 2023

No, it's not a secret

I meant that every container update (it can be compromised, or dropped by mistake, etc) should be done via PR then while keeping it in a secret allows just modifying repo settings.

The secret is displayed on stdout as "***"
But I print the full path to the report and add it to the PR.

@vvarg229 vvarg229 force-pushed the upload-pages-artifact branch 4 times, most recently from d5c2184 to a2e6983 Compare July 7, 2023 12:28
@vvarg229 vvarg229 marked this pull request as ready for review July 28, 2023 14:53
roman-khimov
roman-khimov reviewed Jul 28, 2023
View reviewed changes
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
@vvarg229 vvarg229 force-pushed the upload-pages-artifact branch 5 times, most recently from 4515241 to 84a6054 Compare July 28, 2023 16:30
@vvarg229
workflow: Change neofs-dev-env ref
41367ec 
Until nspcc-dev/neofs-dev-env#272 is merged, the ref
should change to a temporary branch.

Signed-off-by: Oleg Kulachenko <[email protected]>
@vvarg229
workflow: Add a deploying Allure reports to NeoFS nspcc-dev#2324
6f3fa71 
nspcc-dev/neofs-testcases#574

Added a workflow for deploy Allure tests result as static
web page to NeoFS.

This new functionality will help to save any test report as an
object in the NeoFS network, we will become independent of
the limitations of the GitHub branches and pages.

It will also be an "advertisement" for our object storage.

Signed-off-by: Oleg Kulachenko <[email protected]>
@roman-khimov roman-khimov merged commit 950ee7c into nspcc-dev:master Jul 28, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell left review comments

@roman-khimov roman-khimov roman-khimov approved these changes

@532910 532910 Awaiting requested review from 532910

@aprasolova aprasolova Awaiting requested review from aprasolova

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vvarg229 @carpawell @roman-khimov