Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to increment internal CFBundleShortVersionString in v1.6 release #311

Open
noah978 opened this issue Mar 29, 2023 · 6 comments
Open
Assignees

Comments

@noah978
Copy link

noah978 commented Mar 29, 2023

Just wanted to leave a note that the internal version in the IPA released with v1.6 was not properly updated from v1.5. As such it can break things (like my auto-updating AltStore Source that pulls from the Github releases).

Thanks!

@adriweb
Copy link
Member

adriweb commented Mar 29, 2023

Yep I had noticed this but honestly it was too annoying to redo (nothing is automated on this side) for just that change... so, meh :(

@Vogtinator
Copy link
Member

Was the IPA built before d39ca63?

@core-code
Copy link

its not just that the version number has not increased, it was completely removed altogether

the previous release had a proper bundle-identifier ( com.adriweb.firebird-emu ) and proper version numbers (1.5) stored in both CFBundleShortVersionString as well as CFBundleVersion

the new release has a changed and generic identifier (com.yourcompany.firebird-emu) and has no version numbers stored in the app at all.

we cannot support updating to the new release in MacUpdater as long as these issues exist.

@adriweb
Copy link
Member

adriweb commented Mar 29, 2023 via email

@Vogtinator
Copy link
Member

the new release has a changed and generic identifier (com.yourcompany.firebird-emu) and has no version numbers stored in the app at all.

That sounds like Info.plist wasn't used during build at all, it defines all those things correctly...

@adriweb
Copy link
Member

adriweb commented Mar 29, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants