Custom exception does not work in SentryInterceptor

[kikefajardoh]

Hello, I'm able to intercept exceptions using the example that exists in docs:

new SentryInterceptor({filters: [
    {
      type: HttpException,
      filter: (exception: HttpException) => {        
        return (500 > exception.getStatus());
      },
    }
]})

But when I try to track custom exception sentry interceptor does not work properly:

new SentryInterceptor({filters: [
    {
      type: CustomHttpException,
      filter: (exception: CustomHttpException) => {        
        return (exception.getLogInSentry());
      },
    }
]})

Another thing that I found is when I evaluate exception status it works:

new SentryInterceptor({filters: [
    {
      type: CustomHttpException,
      filter: (exception: CustomHttpException) => {        
        return (404 > exception.getStatus()); // 404 it's the current status of the exception
      },
    }
]})

This is the definition of CustomHttpException:

export class CustomHttpException extends HttpException {
    logInSentry: boolean;

    constructor(response: string | Record<string, any>, status: number, logInSentry = false) {
        super(response, status);
        this.logInSentry = logInSentry;
    }

    getLogInSentry(): boolean {
        return this.logInSentry;
    }
}

[daniel-tmp]

I think that pr #95 is wrong.

I think
If filter option means filter OUT then original code is correct,
and if it means filter IN then not operator at 110 line must be removed.

[kikefajardoh]

@daniel-tmp it's possible to revert this?

[rjurado01]

As it is now, if you have multiple filters, it always reported to Senty all errors because this code always returns true:

return filters.some(({ type, filter }) => {
  return !(exception instanceof type && (!filter || filter(exception)));
});

Example:

new SentryInterceptor({filters: [
    {
      type: HttpException,
      filter: (exception: HttpException) => {        
        return (500 > exception.getStatus());
      },
    },
    {
      type: MyCustomError
    }
]})

• When throws exception = HttpException
• exception instanceof MyCustomError = false
• !(false && ...) = true
• some([true, ....]) = true

It mus't be reverted to use every.

[gregoryorton-ws]

did this get reverted?