Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'rimraf' unused dependency #120

Open
vicent4no opened this issue Feb 1, 2024 · 4 comments · May be fixed by #124
Open

Remove 'rimraf' unused dependency #120

vicent4no opened this issue Feb 1, 2024 · 4 comments · May be fixed by #124

Comments

@vicent4no
Copy link

vicent4no commented Feb 1, 2024

Apparently it is not being used anywhere in the library.

It can create versioning issues with other packages.

package.json

  "peerDependencies": {
    "@nestjs/common": ">=10.0.0",
    "@nestjs/core": ">=10.0.0",
    "@sentry/hub": "^7.7.0",
    "@sentry/node": "^7.7.0",
    "reflect-metadata": "^0.1.13",
    "rimraf": "^3.0.2",  <- remove
    "rxjs": "^7.2.0"
}
@bakasmarius bakasmarius linked a pull request Jun 12, 2024 that will close this issue
@bakasmarius
Copy link

rimraf is actually used in clean script in package.json, but it cannot be used by users of the library, so I updated it and moved it to optionalDependencies in my PR

@vicent4no
Copy link
Author

@bakasmarius Thanks!

@moskeyombus
Copy link

Can we get this released? This bad dependency causes multiple deprecation warnings

@vicent4no
Copy link
Author

I think that you should migrate to the official (in beta, but maintained) Sentry NestJS integration

https://www.npmjs.com/package/@sentry/nestjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants