Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optionalDependencies for nestjs/graphql to 10.x.x #83

Open
christopheblin opened this issue May 20, 2022 · 3 comments
Open

Allow optionalDependencies for nestjs/graphql to 10.x.x #83

christopheblin opened this issue May 20, 2022 · 3 comments

Comments

@christopheblin
Copy link

Replace

  "optionalDependencies": {
    "@nestjs/graphql": "^8.0.2 || ^9.0.4"
  }

by

  "optionalDependencies": {
    "@nestjs/graphql": "^8.0.2 || ^9.0.4 || ^10.0.11"
  }

to allow user of nestjs/graphql to upgrade to 10.0.11 without having a duplicate depency on nestjs/graphql 9.1.2 (which is the latest version compatible with the current range)

@F3n67u
Copy link

F3n67u commented Nov 10, 2022

optionalDependencies already update to allow @nestjs/graphql

https://github.com/ntegral/nestjs-sentry/blob/f80c538bb827450bcd5bfb07e22b1d35ee8a12d9/package.json#LL70-L72C4

@andrei2424
Copy link

Please, update @nestjs/graphql to >= 11.0.0, there are conflicts with other packages

@ChopperLee2011
Copy link

@nestjs/graphql is 12.2.0 now, could @ntegral/nestjs-sentry be optimistically install the latest version like

  "optionalDependencies": {
    "@nestjs/graphql": "^12.0.11"
  }

to fix some existing and potential vulnerability issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants