Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password needed even when I'm logged in on the web #33

Open
dbarnes10 opened this issue Jul 16, 2019 · 8 comments
Open

password needed even when I'm logged in on the web #33

dbarnes10 opened this issue Jul 16, 2019 · 8 comments
Assignees

Comments

@dbarnes10
Copy link

No description provided.

@ah548455 ah548455 assigned ah548455 and ntoand and unassigned ah548455 Jul 21, 2019
@ah548455
Copy link

Hi David,

Can you describe this a little bit further please ?
We have account passwords and "dataset passwords" For now your comment is too ambiguous.

cheers

@dbarnes10
Copy link
Author

dbarnes10 commented Jul 23, 2019 via email

@ntoand
Copy link
Owner

ntoand commented Jul 23, 2019

@dbarnes10 The current problem is the viewers are independent with previs. In viewers, we don't know which user is viewing it. I may need a bit of work to add firebase auth to the viewers.

@dbarnes10
Copy link
Author

dbarnes10 commented Jul 23, 2019 via email

@ah548455
Copy link

@daelwarn Have a look at the above please.
And please don't hesitate to ask if you have no idea what I am talking about :)

@daelwarn
Copy link
Contributor

For now, it seems mushroom can access those datasets without restriction, I believe the access mechanism used to retrieve the data isn't protected by previs.

@ntoand
Copy link
Owner

ntoand commented Jul 23, 2019

@dbarnes10 @ah548455 Actually we can achieve it easily by generating a temp key when a user logs in to previs. We then use the temp key to view datasets. I will implement it when having some time.

@ntoand
Copy link
Owner

ntoand commented Jul 23, 2019

mushroom only can access the datasets via an API key (generated for mushroom app). Without the API key, you cannot get datasets' locations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants