PF_RING with kernel 5.6.3 - compilation problem

[mapetenator]

I tried to compile PF_RING with the new kernel version...

#make -C /lib/modules/5.6.3/build SUBDIRS=/usr/src/PF_RING/kernel EXTRA_CFLAGS='-I/usr/src/PF_RING/kernel -DGIT_REV=""dev:12fa75e4487bc6b91fef8e8448790131a2f6b004"" -no-pie -fno-pie -Wno-implicit-fallthrough' modules
make -C /lib/modules/5.6.3/build M=/usr/src/PF_RING/kernel EXTRA_CFLAGS='-I/usr/src/PF_RING/kernel -DGIT_REV=""dev:12fa75e4487bc6b91fef8e8448790131a2f6b004"" -no-pie -fno-pie -Wno-implicit-fallthrough' modules
make[1]: warning: jobserver unavailable: using -j1. Add '+' to parent make rule.
make[1]: Entering directory '/usr/src/linux-5.6.3'
CC [M] /usr/src/PF_RING/kernel/pf_ring.o
In file included from /usr/src/PF_RING/kernel/pf_ring.c:131:0:
/usr/src/PF_RING/kernel/linux/pf_ring.h:339:18: error: field 'ts' has incomplete type
struct timeval ts; /* time stamp */
^~
/usr/src/PF_RING/kernel/pf_ring.c: In function 'ring_proc_add':
/usr/src/PF_RING/kernel/pf_ring.c:1058:63: error: passing argument 4 of 'proc_create_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
proc_create_data(pfr->sock_proc_name, 0, netns->proc_dir, &ring_proc_fops, pfr);
^
In file included from /usr/src/PF_RING/kernel/pf_ring.c:99:0:
./include/linux/proc_fs.h:59:31: note: expected 'const struct proc_ops *' but argument is of type 'const struct file_operations *'
extern struct proc_dir_entry *proc_create_data(const char , umode_t,
^~~~~~~~~~~~~~~~
/usr/src/PF_RING/kernel/pf_ring.c: In function 'ring_proc_init':
/usr/src/PF_RING/kernel/pf_ring.c:1713:6: error: passing argument 4 of 'proc_create' from incompatible pointer type [-Werror=incompatible-pointer-types]
&ring_proc_fops / file operations */);
^
In file included from /usr/src/PF_RING/kernel/pf_ring.c:99:0:
./include/linux/proc_fs.h:64:24: note: expected 'const struct proc_ops *' but argument is of type 'const struct file_operations *'
struct proc_dir_entry *proc_create(const char *name, umode_t mode, struct proc_dir_entry *parent, const struct proc_ops proc_ops);
^~~~~~~~~~~
/usr/src/PF_RING/kernel/pf_ring.c: In function 'set_skb_time':
/usr/src/PF_RING/kernel/pf_ring.c:2838:13: error: implicit declaration of function 'ktime_to_timeval' [-Werror=implicit-function-declaration]
hdr->ts = ktime_to_timeval(skb->tstamp);
^~~~~~~~~~~~~~~~
/usr/src/PF_RING/kernel/pf_ring.c: In function 'add_virtual_filtering_device':
/usr/src/PF_RING/kernel/pf_ring.c:4566:8: error: passing argument 4 of 'proc_create_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
&ring_proc_virtual_filtering_fops / read */,
^
In file included from /usr/src/PF_RING/kernel/pf_ring.c:99:0:
./include/linux/proc_fs.h:59:31: note: expected 'const struct proc_ops *' but argument is of type 'const struct file_operations *'
extern struct proc_dir_entry *proc_create_data(const char *, umode_t,
^~~~~~~~~~~~~~~~
/usr/src/PF_RING/kernel/pf_ring.c: In function 'setSocketStats':
/usr/src/PF_RING/kernel/pf_ring.c:6624:9: error: passing argument 4 of 'proc_create_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
&ring_proc_stats_fops, pfr)) == NULL) {
^
In file included from /usr/src/PF_RING/kernel/pf_ring.c:99:0:
./include/linux/proc_fs.h:59:31: note: expected 'const struct proc_ops *' but argument is of type 'const struct file_operations *'
extern struct proc_dir_entry *proc_create_data(const char , umode_t,
^~~~~~~~~~~~~~~~
/usr/src/PF_RING/kernel/pf_ring.c: In function 'add_device_to_proc':
/usr/src/PF_RING/kernel/pf_ring.c:8219:5: error: passing argument 4 of 'proc_create_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
&ring_proc_dev_fops / read */,
^
In file included from /usr/src/PF_RING/kernel/pf_ring.c:99:0:
./include/linux/proc_fs.h:59:31: note: expected 'const struct proc_ops *' but argument is of type 'const struct file_operations *'
extern struct proc_dir_entry *proc_create_data(const char *, umode_t,
^~~~~~~~~~~~~~~~
/usr/src/PF_RING/kernel/pf_ring.c: At top level:
cc1: warning: unrecognized command line option '-Wno-implicit-fallthrough'
cc1: some warnings being treated as errors
scripts/Makefile.build:267: recipe for target '/usr/src/PF_RING/kernel/pf_ring.o' failed
make[2]: *** [/usr/src/PF_RING/kernel/pf_ring.o] Error 1
Makefile:1683: recipe for target '/usr/src/PF_RING/kernel' failed
make[1]: *** [/usr/src/PF_RING/kernel] Error 2
make[1]: Leaving directory '/usr/src/linux-5.6.3'
Makefile:66: recipe for target 'all' failed
make: *** [all] Error 2

[cardigliano]

@mapetenator what OS are you running? Please note we officially support latest Ubuntu/Centos/Debian LTS kernels. We will do our best to support also the latest one.

[mapetenator]

Hi,
thank you for your response.
I use Debian GNU/Linux 9.12 (stretch).
Sorry, I didn't know you only support the official version.
I will be grateful for your help.

[emanuele-f]

We will add a temporary fix for this, but the long time solution is to implement #578

[emanuele-f]

Fixed in 67a5ddd , 72b0946 and 4baed06

[mapetenator]

Thank you very much!

[wlcrack]

thank you sir , @emanuele-f and @cardigliano , it works wery well!