Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up terrible Path-str-String handling #7

Open
Fishrock123 opened this issue Aug 6, 2016 · 1 comment
Open

clean up terrible Path-str-String handling #7

Fishrock123 opened this issue Aug 6, 2016 · 1 comment

Comments

@Fishrock123
Copy link
Member

The Path <- str -> String logic littered all over the place from the addition of bundling should probably be cleaned up.

It's a mess and full of .unwrap()s with potential panics. For many of these spots it may be better to handle using OsString, some Path crate, or something else from the stdlib that I am missing.

@creationix
Copy link
Member

Stuff like this is why I bought tickets to rustconf and signed up for the workshops. I'm hoping that I will understand more best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants