Skip to content

import from '/@nue/view-transitions.js' activates view transitions #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wgehner opened this issue Mar 21, 2025 · 1 comment
Open

import from '/@nue/view-transitions.js' activates view transitions #517

wgehner opened this issue Mar 21, 2025 · 1 comment
Labels
nuekit Related to nuekit package

Comments

@wgehner
Copy link

wgehner commented Mar 21, 2025

Describe the Bug

Having this in dhtml

import { $, $$, loadPage } from '/@nue/view-transitions.js'

appears to override site.yaml view_transitions:false

Same for

import { $ } from '/@nue/view-transitions.js'

So I can't seem to use this DOM helper without activating app-router.

Environment

Mac RC2

Minimal Reproduction

  • Set site.yaml view_transitions:false

  • navigate to Contact page

  • navigate between Contact and Home

Watch browser devtools network for page loading activity

@nobkd
Copy link
Collaborator

nobkd commented Mar 21, 2025

Seems like the conditions for running the code piece need to be changed. Starting here some code is run, by just loading the file: https://github.com/nuejs/nue/blob/master/packages%2Fnuekit%2Fsrc%2Fbrowser%2Fview-transitions.js#L109

@nobkd nobkd added the nuekit Related to nuekit package label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nuekit Related to nuekit package
Projects
None yet
Development

No branches or pull requests

2 participants