You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the install script assumes bash and doesn't update the correct *rc file for other shells. In my case, I use Zsh and the relevant file is ~/.zshrc.
In that specific case, it's easy enough to check for a ~/.zshrc file and update that instead of (or in addition to?) ~/.bashrc. There's also the option to do something smart by checking whatever $SHELL is set to.
Thinking about supporting additional shells is what makes this a bit more complicated. I assume things like FISH, and OIL have similar files, but I'm not familiar with them so that makes testing/maintenance hard.
On the other hand, requiring devs to live in bash is a bit restrictive.
We probably shouldn't be directly updating the user's rc files anyway. I know one approach, such as used by OpenFoam, is to:
Create an rc snippet in somewhere user-accessble (like $HOME/.config/<appname>)
On installation tell the user to source $HOME/.config/<appname>/.<shell>rc when they want to run the app
Assume users who don't want to source every time/use a different shell know enough will be able to grab the relevant bits from that file and
a. Incorporate it into their ~/.rc
b. Adapt the snippet to their preferred shell
Not a big deal overall, just trying to log these as issues while I'm still a beginner at NUFEB dev and before I forget them.
There's similar issues with the third party installs, which should be written up as an issue as well.
The text was updated successfully, but these errors were encountered:
Right now, the install script assumes bash and doesn't update the correct *rc file for other shells. In my case, I use Zsh and the relevant file is
~/.zshrc
.In that specific case, it's easy enough to check for a
~/.zshrc
file and update that instead of (or in addition to?)~/.bashrc
. There's also the option to do something smart by checking whatever $SHELL is set to.Thinking about supporting additional shells is what makes this a bit more complicated. I assume things like FISH, and OIL have similar files, but I'm not familiar with them so that makes testing/maintenance hard.
On the other hand, requiring devs to live in bash is a bit restrictive.
We probably shouldn't be directly updating the user's rc files anyway. I know one approach, such as used by OpenFoam, is to:
$HOME/.config/<appname>
)source $HOME/.config/<appname>/.<shell>rc
when they want to run the appsource
every time/use a different shell know enough will be able to grab the relevant bits from that file anda. Incorporate it into their ~/.rc
b. Adapt the snippet to their preferred shell
Not a big deal overall, just trying to log these as issues while I'm still a beginner at NUFEB dev and before I forget them.
There's similar issues with the third party installs, which should be written up as an issue as well.
The text was updated successfully, but these errors were encountered: