fix(tools): kill child process on timeout

Fix
nuke-build · Dec 19, 2023 · 5d1de2e · 5d1de2e
1 parent 30aa4a8
commit 5d1de2e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/source/Nuke.Tooling/IProcess.cs b/source/Nuke.Tooling/IProcess.cs
@@ -54,7 +54,7 @@ public interface IProcess : IDisposable
     /// <summary>
     /// Calls <see cref="Process.Kill()"/>.
     /// </summary>
-    void Kill();
+    void Kill(bool entireProcessTree = false);
 
     /// <summary>
     /// Waits for the process to exit. If the process is not exiting within a given timeout, <see cref="Kill"/> is called.

diff --git a/source/Nuke.Tooling/Process2.cs b/source/Nuke.Tooling/Process2.cs
@@ -42,9 +42,9 @@ public void Dispose()
         _process.Dispose();
     }
 
-    public void Kill()
+    public void Kill(bool entireProcessTree = false)
     {
-        _process.Kill();
+        _process.Kill(entireProcessTree);
     }
 
     public bool WaitForExit()
@@ -53,7 +53,7 @@ public bool WaitForExit()
         // use _process.StartTime
         var hasExited = _process.WaitForExit(_timeout ?? -1);
         if (!hasExited)
-            _process.Kill();
+            _process.Kill(entireProcessTree: true);
         return hasExited;
     }
 }