Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1670 - Lower part album text disappear issue #1721

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

u7630748
Copy link
Contributor

Description

This PR addresses the styling inconsistencies reported in Issue #1670 for the AlbumView component. The updates ensure that the album titles are properly aligned and that the text truncation behavior is consistent across different displays.

Changes Made

  1. Updated Album Title Alignment:

    • Added align-items: center; to ensure vertical centering in the album title display.
  2. CSS Property Adjustments:

    • Updated line-height for .album_text to improve readability and spacing.

Screenshots

Before Changes:
image

After Changes: (Now the letter with descender like "g", "y" are visible)
Screenshot 2024-10-16 at 5 21 44 PM

Testing

  • Run the linter and passed
  • Run the npm test and passed

@u7630748 u7630748 changed the title Fix/1670 Fix/1670 - Lower part album text disappear issue Oct 16, 2024
@nukeop
Copy link
Owner

nukeop commented Oct 16, 2024

Very nice, thank you.

@nukeop nukeop merged commit e0d20e2 into nukeop:master Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants