fix(DiskUtil): Fixed NPE crashes trying to get directory size

null2264 · null2264 · commit a2b47ab2444c · 2024-09-05T06:50:52.000+07:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -10,4 +10,4 @@
 ## Other  ?? Technical stuff, what happened behind the scene
 -->
 ## Fixes
-- Fixed NPE crash on tablets
+- Fixed more NPE crashes
diff --git a/app/src/main/java/eu/kanade/tachiyomi/util/storage/DiskUtil.kt b/app/src/main/java/eu/kanade/tachiyomi/util/storage/DiskUtil.kt
@@ -20,7 +20,7 @@ object DiskUtil {
     fun getDirectorySize(f: File): Long {
         var size: Long = 0
         if (f.isDirectory) {
-            for (file in f.listFiles()!!) {
+            for (file in f.listFiles().orEmpty()) {
                 size += getDirectorySize(file)
             }
         } else {

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ object DiskUtil {`
`20`	`20`	`fun getDirectorySize(f: File): Long {`
`21`	`21`	`var size: Long = 0`
`22`	`22`	`if (f.isDirectory) {`
`23`		`- for (file in f.listFiles()!!) {`
	`23`	`+ for (file in f.listFiles().orEmpty()) {`
`24`	`24`	`size += getDirectorySize(file)`
`25`	`25`	`}`
`26`	`26`	`} else {`