Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobuf Dependency to Support Version >=5.0 #204

Open
8 tasks
rishhavv opened this issue Jan 17, 2025 · 3 comments
Open
8 tasks

Update protobuf Dependency to Support Version >=5.0 #204

rishhavv opened this issue Jan 17, 2025 · 3 comments
Assignees

Comments

@rishhavv
Copy link

Description

Currently, pynumaflow specifies the protobuf dependency as protobuf = ">=3.20,<5.0". This restricts the use of protobuf versions greater than or equal to 5.0.

With the release of protobuf 5.0, there are several performance improvements, bug fixes, and potential new features that could benefit pynumaflow. To ensure the library stays up-to-date and compatible with modern dependency requirements, it would be valuable to investigate the feasibility of updating this dependency constraint.


Proposed Changes

  1. Update the protobuf dependency in the pyproject.toml file to allow protobuf >= 5.0 (e.g., protobuf = ">=3.20,<6.0" or remove the upper bound if no issues are found with newer versions).
  2. Test the compatibility of pynumaflow with protobuf 5.0+:
    • Run the existing test suite to identify any breaking changes.
    • Verify compatibility with pynumaflow’s functionality and ensure no performance regressions.
  3. Document any changes in behavior due to the new version of protobuf.
  4. Update related documentation, if applicable, to reflect the new dependency requirements.

Acceptance Criteria

  • Dependency in pyproject.toml updated to support protobuf >= 5.0.
  • All tests pass successfully with protobuf >= 5.0.
  • No significant regressions or compatibility issues identified.
  • Documentation is updated to reflect the changes.

Tasks

  • Investigate the current dependency constraint and determine if it is still required.
  • Test with protobuf >= 5.0 and identify any breaking changes.
  • Update the dependency definition and release notes if no issues are found.
  • Communicate changes to stakeholders and update documentation.
@rishhavv
Copy link
Author

@vigith This is a blocker for our usecase, i can pick this up.

@kohlisid
Copy link
Contributor

Hey @rishhavv
Thanks for taking this up!
Like you mentioned let's ensure that there is no regression with the new version.
We would like to test e2e with different UDFs for complete coverage.

@rishhavv
Copy link
Author

sounds good - i'm picking this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants