You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, pynumaflow specifies the protobuf dependency as protobuf = ">=3.20,<5.0". This restricts the use of protobuf versions greater than or equal to 5.0.
With the release of protobuf 5.0, there are several performance improvements, bug fixes, and potential new features that could benefit pynumaflow. To ensure the library stays up-to-date and compatible with modern dependency requirements, it would be valuable to investigate the feasibility of updating this dependency constraint.
Proposed Changes
Update the protobuf dependency in the pyproject.toml file to allow protobuf >= 5.0 (e.g., protobuf = ">=3.20,<6.0" or remove the upper bound if no issues are found with newer versions).
Test the compatibility of pynumaflow with protobuf 5.0+:
Run the existing test suite to identify any breaking changes.
Verify compatibility with pynumaflow’s functionality and ensure no performance regressions.
Document any changes in behavior due to the new version of protobuf.
Update related documentation, if applicable, to reflect the new dependency requirements.
Acceptance Criteria
Dependency in pyproject.toml updated to support protobuf >= 5.0.
All tests pass successfully with protobuf >= 5.0.
No significant regressions or compatibility issues identified.
Documentation is updated to reflect the changes.
Tasks
Investigate the current dependency constraint and determine if it is still required.
Test with protobuf >= 5.0 and identify any breaking changes.
Update the dependency definition and release notes if no issues are found.
Communicate changes to stakeholders and update documentation.
The text was updated successfully, but these errors were encountered:
Hey @rishhavv
Thanks for taking this up!
Like you mentioned let's ensure that there is no regression with the new version.
We would like to test e2e with different UDFs for complete coverage.
Description
Currently,
pynumaflow
specifies theprotobuf
dependency asprotobuf = ">=3.20,<5.0"
. This restricts the use ofprotobuf
versions greater than or equal to5.0
.With the release of
protobuf 5.0
, there are several performance improvements, bug fixes, and potential new features that could benefitpynumaflow
. To ensure the library stays up-to-date and compatible with modern dependency requirements, it would be valuable to investigate the feasibility of updating this dependency constraint.Proposed Changes
protobuf
dependency in thepyproject.toml
file to allowprotobuf >= 5.0
(e.g.,protobuf = ">=3.20,<6.0"
or remove the upper bound if no issues are found with newer versions).pynumaflow
withprotobuf 5.0+
:pynumaflow
’s functionality and ensure no performance regressions.protobuf
.Acceptance Criteria
pyproject.toml
updated to supportprotobuf >= 5.0
.protobuf >= 5.0
.Tasks
protobuf >= 5.0
and identify any breaking changes.The text was updated successfully, but these errors were encountered: