🌐(frontend) add localization to editor #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanchoutNathan
force-pushed
the
feature/translate-blocknote
branch
from
9f4ee70
to
e97152a
Compare
AntoLC
approved these changes
Oct 22, 2024
src/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteEditor.tsx
Show resolved
Hide resolved
PanchoutNathan
force-pushed
the
feature/translate-blocknote
branch
from
e97152a
to
ab10fcd
Compare
Currently, when you change language the editor does not change. So we add this functionality
PanchoutNathan
force-pushed
the
feature/translate-blocknote
branch
from
ab10fcd
to
6ef056b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, when you change language the editor does not change. So we add this functionality
Proposal
I suggest we use the default translations already offered by blocknotejs and reload the editor whenever a new language is selected.
close #271