From ddcdfef96fba8adfb47deba7eadffa5f40a6e4b5 Mon Sep 17 00:00:00 2001
From: Anthony LC <anthony.le-courric@mail.numerique.gouv.fr>
Date: Mon, 19 Feb 2024 15:50:55 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(i18n)=20dot=20in=20key=20was=20not?=
 =?UTF-8?q?=20added?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The parser was not adding the dot in the key to the
json file sent to crowdin. Some translations were
not being translated correctly.
---
 src/frontend/apps/desk/src/i18n/translations.json         | 8 +++-----
 src/frontend/packages/i18n/__tests__/translations.test.ts | 2 +-
 src/frontend/packages/i18n/i18next-parser.config.jest.mjs | 1 +
 src/frontend/packages/i18n/i18next-parser.config.mjs      | 1 +
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/frontend/apps/desk/src/i18n/translations.json b/src/frontend/apps/desk/src/i18n/translations.json
index c7b3c9b21..b0f7bc8a5 100644
--- a/src/frontend/apps/desk/src/i18n/translations.json
+++ b/src/frontend/apps/desk/src/i18n/translations.json
@@ -1,7 +1,7 @@
 {
   "fr": {
     "translation": {
-      "Create a team": "Créer un groupe",
+      "Create a team.": "Créer un groupe",
       "Marianne Logo": "Logo Marianne",
       "Freedom Equality Fraternity Logo": "Logo Liberté Égalité Fraternité",
       "Desk Logo": "Logo Desk",
@@ -29,15 +29,13 @@
       "Teams icon": "Icône de groupe",
       "Empty teams icon": "Icône de groupe vide",
       "Something bad happens, please refresh the page": "Une erreur inattendue s'est produite, rechargez la page.",
-      "0 group to display": "0 groupe à afficher.",
-      "Create your first team by clicking on the \"Create a new team\" button": "Créez votre premier groupe en cliquant sur le bouton \"Créer un nouveau groupe\".",
+      "0 group to display.": "0 groupe à afficher.",
       "Create new team card": "Carte créer une nouvelle équipe",
       "Something bad happens, please retry.": "Une erreur inattendue s'est produite, rechargez la page.",
-      "0 group to display.": "0 groupe à afficher.",
       "Create your first team by clicking on the \"Create a new team\" button.": "Créez votre premier groupe en cliquant sur le bouton \"Créer un nouveau groupe\".",
       "Something bad happens, please refresh the page.": "Une erreur inattendue s'est produite, rechargez la page.",
       "Members of “{{teamName}}“": "Membres de “{{teamName}}“",
-      "Add people to the “{{teamName}}“ group": "Ajouter des personnes au groupe «{{teamName}}».",
+      "Add people to the “{{teamName}}“ group.": "Ajouter des personnes au groupe “{{teamName}}“.",
       "{{count}} member_one": "{{count}} membre",
       "{{count}} member_many": "{{count}} membres",
       "{{count}} member_other": "{{count}} membres",
diff --git a/src/frontend/packages/i18n/__tests__/translations.test.ts b/src/frontend/packages/i18n/__tests__/translations.test.ts
index 856ba3795..af37582d5 100644
--- a/src/frontend/packages/i18n/__tests__/translations.test.ts
+++ b/src/frontend/packages/i18n/__tests__/translations.test.ts
@@ -29,7 +29,7 @@ describe('checks all the frontend translation are made', () => {
 
         if (missingKeys.length > 0) {
           console.log(
-            `Missing keys in Desk translations that should be translated in Crowdin, got to https://crowdin.com/:`,
+            `Missing keys in Desk translations that should be translated in Crowdin, got to https://crowdin.com/ :`,
             missingKeys,
           );
         }
diff --git a/src/frontend/packages/i18n/i18next-parser.config.jest.mjs b/src/frontend/packages/i18n/i18next-parser.config.jest.mjs
index d212c1f49..ad2126c74 100644
--- a/src/frontend/packages/i18n/i18next-parser.config.jest.mjs
+++ b/src/frontend/packages/i18n/i18next-parser.config.jest.mjs
@@ -4,6 +4,7 @@ const config = {
     description: '${description}',
   },
   keepRemoved: false,
+  keySeparator: false,
 };
 
 export default config;
diff --git a/src/frontend/packages/i18n/i18next-parser.config.mjs b/src/frontend/packages/i18n/i18next-parser.config.mjs
index cc51b2572..8322d3ab3 100644
--- a/src/frontend/packages/i18n/i18next-parser.config.mjs
+++ b/src/frontend/packages/i18n/i18next-parser.config.mjs
@@ -4,6 +4,7 @@ const config = {
     description: '${description}',
   },
   keepRemoved: true,
+  keySeparator: false,
 };
 
 export default config;