Fetch and display commune name #583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morendil
force-pushed
the
org-and-domain
branch
from
1d25f59 to
3481e93
Compare
Morendil
changed the title
Morendil
force-pushed
the
org-and-domain
branch
4 times, most recently
from
b940300 to
003b150
Compare
This was referenced Jan 5, 2025
|
@PanchoutNathan On est pas dans les clous par rapport à la maquette: est-ce que tu aurais le temps (genre dans la semaine) de committer ou suggérer ce qu'il faudrait faire ? Sinon on peut merger et corriger plus tard… Thx 🙏 
|
mjeammet
approved these changes
Jan 7, 2025
ANCT-specific extraction of organization names for communes, front end changes to match.
Morendil
force-pushed
the
org-and-domain
branch
from
003b150 to
000a458
Compare
|
@mjeammet This failed in CI for an interesting reason - the API is rate-limited and we got a 429 error. I don't know how we managed to exceed 7 calls/sec. with only one E2E test exercising it… Not sure how best to proceed - perhaps implement retry logic, or try a different API, or use static data… it raises the question of how to deal with failure cases for something like this where the request is made at a specific point in the lifetime of an organization, and not retried afterward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
New users from communes should be able to make sense of what they can do with Régie.
Proposal
When arriving at Régie from ProConnect, make sure things are set up properly:
Fixes #610