Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing auto logodds_eps to reflect data size #30

Open
blucena opened this issue Jul 16, 2020 · 0 comments
Open

Consider changing auto logodds_eps to reflect data size #30

blucena opened this issue Jul 16, 2020 · 0 comments

Comments

@blucena
Copy link
Contributor

blucena commented Jul 16, 2020

Right now, when SplineCalib chooses logodds_eps automatically, it does so by looking at the smallest and largest values. However, perhaps it should also consider the size of the calibration set. For example, with 1,000 calibration points, it will be impossible to determine the difference between a 1 in 10,000 event and a 1 in 100,000 event. So perhaps, it should use a logodds_eps around .001 in this case. Still need to think about this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant