selecting TLS support

Author: SwayamInSync

quaddtype/meson.build

@@ -30,6 +30,44 @@ if openmp_dep.found()
     dependencies += openmp_dep
 endif
 
+# Thread-local storage detection (borrowed from NumPy)
+optional_variable_attributes = [
+  ['thread_local', 'HAVE_THREAD_LOCAL'],    # C23
+  ['_Thread_local', 'HAVE__THREAD_LOCAL'],  # C11/C17
+  ['__thread', 'HAVE___THREAD'],           # GCC/Clang
+  ['__declspec(thread)', 'HAVE___DECLSPEC_THREAD_']  # MSVC
+]
+
+if not is_variable('cdata')
+  cdata = configuration_data()
+endif
+
+foreach optional_attr: optional_variable_attributes
+  attr = optional_attr[0]
+  code = '''
+    #pragma GCC diagnostic error "-Wattributes"
+    #pragma clang diagnostic error "-Wattributes"
+    
+    int @0@ foo;
+    
+    int main() {
+      return 0;
+    }
+  '''.format(attr)
+  
+  if c.compiles(code, name: optional_attr[0])
+    cdata.set10(optional_attr[1], true)
+    message('Thread-local storage support found: @0@'.format(attr))
+  endif
+endforeach
+
+configure_file(
+  output: 'quaddtype_config.h',
+  configuration: cdata
+)
+
+build_includes = include_directories('.')
+
 includes = include_directories(
     [
         incdir_numpy,
@@ -84,5 +122,5 @@ py.extension_module('_quaddtype_main',
   dependencies: dependencies,
   install: true,
   subdir: 'numpy_quaddtype',
-  include_directories: includes
+  include_directories: [includes, build_includes]
 )

quaddtype/numpy_quaddtype/src/dragon4.c

@@ -11,6 +11,9 @@ Modifications are specific to support the SLEEF_QUAD
 #include <sleef.h>
 #include <sleefquad.h>
 
+#include "quaddtype_config.h"
+
+
 #define PY_ARRAY_UNIQUE_SYMBOL QuadPrecType_ARRAY_API
 #define PY_UFUNC_UNIQUE_SYMBOL QuadPrecType_UFUNC_API
 #define NPY_NO_DEPRECATED_API NPY_2_0_API_VERSION
@@ -22,6 +25,15 @@ Modifications are specific to support the SLEEF_QUAD
 #include "dtype.h"
 #include "scalar.h"
 
+
+#if !defined(HAVE_THREAD_LOCAL) && !defined(HAVE__THREAD_LOCAL) && \
+    !defined(HAVE___THREAD) && !defined(HAVE___DECLSPEC_THREAD_) && \
+    !defined(__cplusplus)
+#warning "No thread-local storage support detected! NPY_TLS will be empty, causing thread safety issues."
+#else
+#warning "NPY_TLS Thread-local storage support detected."
+#endif
+
 #if 0
 #define DEBUG_ASSERT(stmnt) assert(stmnt)
 #else

quaddtype/numpy_quaddtype/src/scalar.c

@@ -15,21 +15,12 @@
 #include "scalar_ops.h"
 #include "dragon4.h"
 
-#ifdef Py_GIL_DISABLED
-static PyMutex scalar_mutex = {0};
-#endif
 
 QuadPrecisionObject *
 QuadPrecision_raw_new(QuadBackendType backend)
 {
     QuadPrecisionObject *new;
-#ifdef Py_GIL_DISABLED
-    PyMutex_Lock(&scalar_mutex);
-#endif
     new = PyObject_New(QuadPrecisionObject, &QuadPrecision_Type);
-#ifdef Py_GIL_DISABLED
-    PyMutex_Unlock(&scalar_mutex);
-#endif
 
     if (!new)
         return NULL;
@@ -196,28 +187,19 @@ QuadPrecision_str(QuadPrecisionObject *self)
 static PyObject *
 QuadPrecision_repr(QuadPrecisionObject *self)
 {
-#ifdef Py_GIL_DISABLED
-    PyMutex_Lock(&scalar_mutex);
-#endif
     PyObject *str = QuadPrecision_str(self);
     if (str == NULL) {
         return NULL;
     }
     const char *backend_str = (self->backend == BACKEND_SLEEF) ? "sleef" : "longdouble";
     PyObject *res = PyUnicode_FromFormat("QuadPrecision('%S', backend='%s')", str, backend_str);
     Py_DECREF(str);
-#ifdef Py_GIL_DISABLED
-    PyMutex_Unlock(&scalar_mutex);
-#endif
     return res;
 }
 
 static PyObject *
 QuadPrecision_repr_dragon4(QuadPrecisionObject *self)
 {
-#ifdef Py_GIL_DISABLED
-    PyMutex_Lock(&scalar_mutex);
-#endif
     Dragon4_Options opt = {.scientific = 1,
                            .digit_mode = DigitMode_Unique,
                            .cutoff_mode = CutoffMode_TotalLength,
@@ -247,9 +229,6 @@ QuadPrecision_repr_dragon4(QuadPrecisionObject *self)
     const char *backend_str = (self->backend == BACKEND_SLEEF) ? "sleef" : "longdouble";
     PyObject *res = PyUnicode_FromFormat("QuadPrecision('%S', backend='%s')", str, backend_str);
     Py_DECREF(str);
-#ifdef Py_GIL_DISABLED
-    PyMutex_Unlock(&scalar_mutex);
-#endif
     return res;
 }