From 795b9f3a96df41b8aa3ff84c59fa2d8e0a62b355 Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Mon, 29 Apr 2024 09:31:54 -0400 Subject: [PATCH 1/6] BUG: Fix bug with validation encoding --- .github/workflows/test.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 02eb7b43..aa905099 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -19,6 +19,10 @@ jobs: python-version: ["3.9", "3.10", "3.11", "3.12"] sphinx-version: ["sphinx==6.0", "sphinx==6.2", "sphinx==7.0", "sphinx>=7.3"] + include: + - os: Windows + python-version: "3.12" + sphinx-version: "sphinx" # version shouldn't really matter here steps: - uses: actions/checkout@v4 From b359e4504b688a6bb4c8a5a50eeb350e36427301 Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Mon, 29 Apr 2024 09:35:55 -0400 Subject: [PATCH 2/6] FIX: Bashy --- .github/workflows/test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index aa905099..06e09854 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -23,6 +23,9 @@ jobs: - os: Windows python-version: "3.12" sphinx-version: "sphinx" # version shouldn't really matter here + defaults: + run: + shell: bash -euo pipefail steps: - uses: actions/checkout@v4 From 0ff70ab7e5641ecfc64fc386c36ea83cdda1726c Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Mon, 29 Apr 2024 09:37:00 -0400 Subject: [PATCH 3/6] FIX: No doc build on Windows --- .github/workflows/test.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 06e09854..e83bec5b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -66,11 +66,13 @@ jobs: run: | sudo apt-get update sudo apt install texlive texlive-latex-extra latexmk dvipng + if: runner.os == 'Linux' - name: Build documentation run: | make -C doc html SPHINXOPTS="-nT" make -C doc latexpdf SPHINXOPTS="-nT" + if: runner.os == 'Linux' prerelease: runs-on: ${{ matrix.os }}-latest From fef4de31d9c0f98fddd280c444a3ac445acb4674 Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Mon, 29 Apr 2024 09:42:14 -0400 Subject: [PATCH 4/6] FIX: Shel --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index e83bec5b..d43ca7b5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -25,7 +25,7 @@ jobs: sphinx-version: "sphinx" # version shouldn't really matter here defaults: run: - shell: bash -euo pipefail + shell: bash -e steps: - uses: actions/checkout@v4 From 821386396e2f45ce65e864740d5d50374599d938 Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Mon, 29 Apr 2024 09:42:41 -0400 Subject: [PATCH 5/6] FIX: Zero --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d43ca7b5..7859098b 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -25,7 +25,7 @@ jobs: sphinx-version: "sphinx" # version shouldn't really matter here defaults: run: - shell: bash -e + shell: bash -euo pipefail {0} steps: - uses: actions/checkout@v4 From 38c1f44c47113e3675ca954e9172687ac18d680b Mon Sep 17 00:00:00 2001 From: Eric Larson Date: Mon, 29 Apr 2024 09:42:57 -0400 Subject: [PATCH 6/6] FIX: User --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7859098b..b58ef62a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -25,7 +25,7 @@ jobs: sphinx-version: "sphinx" # version shouldn't really matter here defaults: run: - shell: bash -euo pipefail {0} + shell: bash -eo pipefail {0} steps: - uses: actions/checkout@v4