Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service.stopCommand or similar for better cleanup #279

Open
kate-shine opened this issue Sep 20, 2023 · 0 comments
Open

service.stopCommand or similar for better cleanup #279

kate-shine opened this issue Sep 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@kate-shine
Copy link

Is your feature request related to a problem? Please describe.

Currently, each serviceGroup creates two shell scripts, <group.name>:start and <group.name>:stop

It's impossible to define how be each service stopped. In some cases, it would be a nice feature to have ability to do it myself (or even define cleanup process)

Examples of commands from my recent devshell that spawns necessary services for running tests:

  • podman stop <container_name>
  • minikube stop

(Default generated :stop script is unable to shut down both spawned minikube and podman containers)

Describe the solution you'd like

Another attribute, for example stopCommand. It could be also an array of commands.

Describe alternatives you've considered

for now, I'm defining "test_cleanup" command for shell that does the same thing, but it feels like a less than ideal approach

Additional context

@kate-shine kate-shine added the enhancement New feature or request label Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant