have the cron job add comments to patches

Author: nunoplopes

cron.php

@@ -174,15 +174,19 @@ function run_patch_stats() {
       try {
         $oldstatus = $patch->getStatus();
         $patch->updateStats();
+        $newstatus = $patch->getStatus();
 
-        if ($patch->getStatus() != $oldstatus) {
+        if ($newstatus != $oldstatus) {
+          $patch->comments->add(
+            new PatchComment($patch,
+              "Status changed: $oldstatus → $newstatus"));
           email_ta($group,
                    "PIC1: Patch $patch->id status changed (group $group)",
                    "Patch $patch->id of group $group changed status from " .
-                   "$oldstatus to " . $patch->getStatus() . "\n" .
+                   "$oldstatus to $newstatus\n" .
                    link_patch($patch));
           echo "Patch $patch->id changed status from $oldstatus to ",
-               $patch->getStatus(), "\n";
+               $newstatus, "\n";
         } else {
           echo "Patch $patch->id status unchanged\n";
         }
@@ -251,6 +255,8 @@ function run_repository() {
             */
           } else {
             $patch->status = PATCH_PR_OPEN_ILLEGAL;
+            $patch->comments->add(
+              new PatchComment($patch, "PR opened without approval"));
             error_group($group,
                         "PIC1: PR opened without approval",
                         "PR $pr of group $group was opened ".
@@ -262,7 +268,7 @@ function run_repository() {
 
         if (!$processed) {
           $patch = Patch::factory($group, $pr->branchURL(), PATCH_BUGFIX, '',
-                                  'Automatically generated', $group->prof(),
+                                  'Automatically generated', null,
                                   /*ignore_errors=*/true);
           $patch->setPR($pr);
           $patch->status = PATCH_PR_OPEN_ILLEGAL;

entities/Patch.php

@@ -83,7 +83,7 @@ abstract class Patch
 
   static function factory(ProjGroup $group, string $url, $type,
                           string $issue_url, string $description,
-                          User $submitter,
+                          ?User $submitter,
                           bool $ignore_errors = false) : Patch {
     $repo = $group->getRepository();
     if (!$repo)

pages/editpatch.php

@@ -25,7 +25,7 @@
 echo "<p>&nbsp;</p>\n";
 mk_box_left_begin();
 
-$prev_status = $patch->status;
+$prev_status = $patch->getStatus();
 
 $new_comment = trim($_POST['text'] ?? '');
 if ($new_comment && get_user()->role == ROLE_STUDENT) {
@@ -44,10 +44,9 @@
 }
 
 if ($new_comment) {
-  if ($patch->status != $prev_status) {
-    $old = Patch::get_status_options()[$prev_status];
-    $new = Patch::get_status_options()[$patch->status];
-    $new_comment = "Status changed: $old → $new\n\n$new_comment";
+  $new_status = $patch->getStatus();
+  if ($new_status != $prev_status) {
+    $new_comment = "Status changed: $prev_status → $new_status\n\n$new_comment";
   }
   $patch->comments->add(new PatchComment($patch, $new_comment, get_user()));
 }
@@ -103,7 +102,7 @@
 mk_box_end();
 
 // notify students of the patch review
-if ($patch->status != $prev_status) {
+if ($patch->getStatus() != $prev_status) {
   $subject = null;
   $patchurl = $patch->getPatchURL();
   $pic1link = link_patch($patch);