Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarklet seems to point to public keycloak instance not to local #7

Open
zoernert opened this issue May 19, 2020 · 6 comments
Open

Comments

@zoernert
Copy link

Looking at the resulting JS Code at:
https://keep.corrently.cloud/keeper/bookmarklet

it has:

<script src="https://login.nunux.org/auth/js/keycloak.js" type="text/javascript"></script>

I assume it should be:

<script src="https://keep.corrently.cloud/auth/js/keycloak.js" type="text/javascript"></script>

I think the code comes directly from the source and is not get customized during a make deploy based on .env settings.

@ncarlier
Copy link
Member

You right! It's hard coded here: https://github.com/nunux-keeper/keeper-web-app/blob/master/public/index.html#L20
It's no big deal as long as you we are using the same Keycloak version.
I should replace this by a template variable.

@ncarlier
Copy link
Member

I just fixed the webapp. Can you pull a fresh keeper-web-app image and retry?

@zoernert
Copy link
Author

I was not able to test as the Bookmarklet does now not honor the K_REALM Url which causes a redirect to the https://keep.corrently.cloud/keeper/keycloak.json => Auth_Server_URL and this does not contain the Servername (see previous issue)

@ncarlier
Copy link
Member

What's the value of K_REALM ?

@zoernert
Copy link
Author

K_REALM="https://keep.corrently.cloud/keeper"

In my Bookmarklet

@ncarlier
Copy link
Member

It's correct... so I don't really understand the pb you have. Bookmarklet is not working as expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants