docker build fails

[Skrylar]

• Fresh clone
• make build start
• Docker crunches for a while
• Fails because of missing dependencies inside the docker image

https://asciinema.org/a/kZG2zJCqKGPxtSQIJ44TzWzGA

[ncarlier]

Hi,

Make start is a little peculiar. It runs the container in "dev mode", in other words, it mounts the current directory as the application directory. So if node modules are not installed locally (node_modules dir ) the container cannot start.

Two options:

• Deactivate the "dev mode": Remove volume directive from https://github.com/nunux-keeper/keeper-web-app/blob/master/docker-compose.yml#L10
• Install node dependencies locally before the make start: run npm install

[Skrylar]

Ok.

The README instructions should be changed from:

Or with Docker:
$ git clone https://github.com/nunux-keeper/keeper-web-app.git
$ cd keeper-web-app
$ make build start # Build Docker image and start it

to:

Or with Docker:
$ git clone https://github.com/nunux-keeper/keeper-web-app.git
$ cd keeper-web-app
$ npm install
$ make build start # Build Docker image and start it

(although this did not produce a working build either, but that's due to compile errors with the dependencies i need to check out.)