Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be selectable upon initial login when 2FA is enforced #35

Open
nursoda opened this issue Nov 27, 2019 · 9 comments
Open

Should be selectable upon initial login when 2FA is enforced #35

nursoda opened this issue Nov 27, 2019 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nursoda
Copy link
Owner

nursoda commented Nov 27, 2019

If you have 2FA enforced on NC and create a new user, that user has to set up 2FA upon 1st login. TOTP and U2F are available upon 1st login, twofactor_email is not but should be.

@gumaol
Copy link

gumaol commented Mar 15, 2020

I logged in as new user and I see the button "enable", but it did not function! No 2FA email would be send!

@ghost
Copy link

ghost commented Apr 28, 2020

I only see totp

@AndyXheli
Copy link

dupe of #83 ?

@nursoda
Copy link
Owner Author

nursoda commented May 24, 2021

I think they could be merged, but I see slightly different scopes:

THIS issue focuses on the fact that twofactor_email may only be chosen AFTER 1st login but not on initial account setup (while other twofactor_ Apps ARE available. So IF an e-mail-address is present in the user account AND twofactor_email is installed, new users should be able to choose twofactor_email also.

#83 asks to even automatically enable and use twofactor_email per default.

@tpokorra
Copy link
Contributor

see this commit for TOTP that introduced "Setup at Login": nextcloud/twofactor_totp@165b0f0
also see the search for LoginSetup: https://github.com/nextcloud/twofactor_totp/search?q=LoginSetup

@nursoda nursoda changed the title twofactor_email should be available as choice when 2FA is enforced for new users Should be selectable upon initial login when 2FA is enforced Sep 30, 2021
@nursoda nursoda added enhancement New feature or request help wanted Extra attention is needed labels Feb 26, 2022
@AndyXheli
Copy link

This would be awesome to have

@StefanoWoerner
Copy link

Hi, what is the progress on this? Are there any blockers that need solving? I'd like to help.

@nursoda
Copy link
Owner Author

nursoda commented Sep 26, 2022

No blockers from outside the app. Just nobody implementing it. I'm not a software developer, I just try my best to maintain this app by formulating requirements and reviewing PRs. There was a PR that I reviewed but the author withdrew it. If you can help here or know someone who could and who cares, please review the old PR or establish contact.

@thomas-mc-work
Copy link

This is the mentioned PR: #357

Can't please someone have a look on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants