Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twofactor_email "works" if enabled with Nextcloud 30 [NOT A BUG] #378

Open
mmccarn opened this issue Sep 14, 2024 · 2 comments
Open

twofactor_email "works" if enabled with Nextcloud 30 [NOT A BUG] #378

mmccarn opened this issue Sep 14, 2024 · 2 comments
Assignees
Labels
compatibility Latest NC version not supported help wanted Extra attention is needed question Further information is requested

Comments

@mmccarn
Copy link

mmccarn commented Sep 14, 2024

twofactor_email (still) works for me in Nextcloud 30 after being enabled manually.

sudo -u www-data php /var/www/nextcloud/occ app:enable twofactor_email

As before, I can:

  • Enter my username & password
  • Request a two factor code by email
  • Receive the code
  • Complete the login

IMPORTANT

I am NOT claiming that the app provides provable security (which I think is why it is not certified with NC after v28), only that the flow works and allows logins.

@mmccarn mmccarn changed the title twofactor_email "works" if enbled with Nextcloud 30 [NOT A BUG] twofactor_email "works" if enabled with Nextcloud 30 [NOT A BUG] Sep 14, 2024
@nursoda
Copy link
Owner

nursoda commented Sep 15, 2024

Actually, I expect twofactor_email to work unchanged (when manually enabled as "untested app") as long as there are no real big breaking changes in nextcloud server and its OCA / OCP frameworks. There are however some security concerns with these frameworks that have been addresses. Thus, a rebuild is necessary. That rebuild rendered several other security issues with development dependencies. I tried to fix them but was not able to. I thought that this is due to older framework components, so I had the app rebased on twofactor_totp as v3. Unfortunately, my dev did not finish the job so far as that I could release it. I tried to fix it myself which obviously wasn't a good idea since I failed after putting several days work in it. I had to do other stuff since then and so, that's the current status. I'm working on it and I got offered both financial support (to hire a dev) and a hand with development. I'll try to do it with the guys a asked beforehand first but will use these resources if we don't succeed. Thanks for such offers, greatly appreciated. Even more, I'd be honored if somebody would like to co-maintain.

But beware that neither Nextcloud nor this app will ever meet the criteria of 'provable security'. This is a formal thing. To do that on a highly asynchronous system as Nextcloud seems not viable to me.

@nursoda nursoda self-assigned this Sep 15, 2024
@nursoda nursoda added help wanted Extra attention is needed question Further information is requested compatibility Latest NC version not supported labels Sep 15, 2024
@BluePixel4k
Copy link

I'm working on it and I got offered both financial support (to hire a dev) and a hand with development. I'll try to do it with the guys a asked beforehand first but will use these resources if we don't succeed.

@nursoda What is the current status? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Latest NC version not supported help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants