Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-F13-4] Ezwatchlist #202

Open
wants to merge 897 commits into
base: master
Choose a base branch
from

Conversation

heze8
Copy link

@heze8 heze8 commented Oct 25, 2019

No description provided.


By: `Team SE-EDU`      Since: `Jun 2016`      Licence: `MIT`
By: `Team CS2103T-F13-4`      Since: `Sept 2019`      Licence: `NUS`

== Setting up

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 34 - the link "diagrams" does not work for your file. However, the original link works for the original addressBook3. Create a section "diagrams" in docs so that the link will work, with every diagram in the .puml form


By: `Team SE-EDU`      Since: `Jun 2016`      Licence: `MIT`
By: `Team CS2103T-F13-4`      Since: `Sept 2019`      Licence: `NUS`

== Setting up

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like most of your URL diagrams are rather similar to the ones already given (except for occasional change in names). If you haven't updated your UML diagrams, please do so.


By: `Team SE-EDU`      Since: `Jun 2016`      Licence: `MIT`
By: `Team CS2103T-F13-4`      Since: `Sept 2019`      Licence: `NUS`

== Setting up
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link for setting up works good job

@@ -295,71 +529,269 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un
[width="59%",cols="22%,<23%,<25%,<30%",options="header",]
|=======================================================================
|Priority |As a ... |I want to ... |So that I can...
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User stories are generally very comprehensive and elaborate, well done!


The following activity diagram summarises the workflow of Search:

image::SearchActivityDiagram.png[]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude image is too large you should try to make it smaller

** Pros: Less calculation needed.
** Cons: Appear less responsive.
// end::statistics[]

// tag::undoredo[]
=== [Proposed] Undo/Redo feature
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagrams / sentences from this section seems like a wholesale copy from the original ab3. Perhaps you would like to consider altering some of the diagrams / functions / sentences such that it is more catered to your project


The following sequence diagram shows how the watch operation works:

image::WatchSequenceDiagram.png[]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the cross, there should not be anymore dashed line, even though we are aware of the technical difficulties in implementing such.

jcjjjared and others added 26 commits November 8, 2019 18:03
… into fridaynight

# Conflicts:
#	src/test/java/seedu/ezwatchlist/logic/commands/CommandResultTest.java
Fixed potential bug in recommendations.
Fixed bug in user guide watch command
Added more WatchCommand tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants